Re: Listview L10

[Paul Rupe]

On 07 Oct 2002, [e-mail] wrote:
> This one fixes a lot of nasty bugs. It also fixes Xnews,
> among other things.

Yeah, it works great now.  Cool. :)
> This one should bring the listview to a decent state.
> I am interested to hear about outstanding problems.

One thing I noticed is that File Open/Save As dialogs in any app now show 
only icons (the filenames are all blank).  I think this must have happened 
somewhere in the L-series of patches, but I haven't delved in to figure out 
which one yet.

Listview L10

[Alexandre Julliard]

Paul Rupe  writes:
> One thing I noticed is that File Open/Save As dialogs in any app now show 
> only icons (the filenames are all blank).  I think this must have happened 
> somewhere in the L-series of patches, but I haven't delved in to figure out 
> which one yet.

Yes I'm seeing this too. The following patch fixes it for me, but I
guess that line was added for a reason...

Index: dlls/comctl32/listview.c
===================================================================
RCS file: /opt/cvs-commit/wine/dlls/comctl32/listview.c,v
retrieving revision 1.186
diff -u -r1.186 listview.c
--- dlls/comctl32/listview.c	7 Oct 2002 22:43:42 -0000	1.186
+++ dlls/comctl32/listview.c	7 Oct 2002 23:34:11 -0000
@@ -596,7 +596,6 @@
    else
    {
        cchTempBufMax = pdi->item.cchTextMax;
-	    pdi->item.pszText = 0; /* make sure we don't process garbage */
    }

pszTempBuf = HeapAlloc(GetProcessHeap(), 0,

Listview L10

[Dimitrie O. Paun]

On October 7, 2002 07:35 pm, Alexandre Julliard wrote:
> Yes I'm seeing this too. The following patch fixes it for me, but I
> guess that line was added for a reason...

Braindamage. Thanks for spotting it. Should be:

Index: dlls/comctl32/listview.c
===================================================================
RCS file: /opt/cvs-commit/wine/dlls/comctl32/listview.c,v
retrieving revision 1.186
diff -u -r1.186 listview.c
--- dlls/comctl32/listview.c	7 Oct 2002 22:43:42 -0000	1.186
+++ dlls/comctl32/listview.c	7 Oct 2002 23:34:11 -0000
@@ -596,7 +596,6 @@
    else
    {
        cchTempBufMax = pdi->item.cchTextMax;
-	    pdi->item.pszText = 0; /* make sure we don't process garbage */
+	    *pdi->item.pszText = 0; /* make sure we don't process garbage */
    }
         pszTempBuf = HeapAlloc(GetProcessHeap(), 0,

I'll include the fix in the next set of patches.