Re: [6/7] [resend] version: Add support for FILE_VER_GET_LOCALISED flag.

[Alexandre Julliard]

Akihiro Sagawa  writes:
> @@ -356,7 +356,10 @@ static BOOL find_pe_resource( HFILE lzfd, DWORD *resLen, DWORD *resOff )
>          TRACE("No resid entry found\n" );
>          goto done;
>      }
> - resPtr = find_entry_language( resPtr, resDir );
> - if ( flags & FILE_VER_GET_LOCALISED )
> -
>    resPtr = find_entry_language( resPtr, resDir );
> - else
> -
>    resPtr = find_entry_default( resPtr, resDir );

This won't do what you want, it will return the first available
resource which may not be English.
> @@ -642,12 +645,12 @@ DWORD WINAPI GetFileVersionInfoSizeExW( DWORD flags, LPCWSTR filename, LPDWORD h
>          SetLastError(ERROR_BAD_PATHNAME);
>          return 0;
>      }
> - if (flags)
> -
>    FIXME("flags 0x%x ignored\n", flags);
> -
>
> if (flags & ~FILE_VER_GET_LOCALISED)
> -
>    FIXME("flags 0x%x ignored\n", flags & ~FILE_VER_GET_LOCALISED);
>
> if ((lzfd = LZOpenFileW( (LPWSTR)filename, &ofs, OF_READ )) != HFILE_ERROR)
>    {
> -
>    magic = find_version_resource( lzfd, &len, &offset );
> -
>    magic = find_version_resource( lzfd, &len, &offset, flags );
>    LZClose( lzfd );
> }

You'd also need to change the FindResourceW call a few lines below.