Re: [11/18] windowscodecs: add test for pixel format conversion

[Alexandre Julliard]

"Vincent Povirk"  writes:
> +START_TEST(testsrc)
> +{
> - CoInitializeEx(NULL, COINIT_APARTMENTTHREADED);
> -
> - test_conversion(&testdata_32bppBGRA, &testdata_32bppBGR, "BGRA -> BGR", 0);
> - test_conversion(&testdata_32bppBGR, &testdata_32bppBGRA, "BGR -> BGRA", 0);
> - test_conversion(&testdata_32bppBGRA, &testdata_32bppBGRA, "BGRA -> BGRA", 0);
> - test_invalid_conversion();
> - test_default_converter();
> -
> - CoUninitialize();
>
> +}

Much better this way, thanks. You should probably rename the test file
to converter.c or something like that though.

[11/18] windowscodecs: add test for pixel format conversion

[Vincent Povirk]

On Fri, Aug 14, 2009 at 4:55 AM, Alexandre Julliard wrote:
> Much better this way, thanks. You should probably rename the test file
> to converter.c or something like that though.

That will be a problem when I want to use the test IWICBitmapSource
with an encoder. Or should I just duplicate the code in another C
file?

[11/18] windowscodecs: add test for pixel format conversion

[Alexandre Julliard]

Vincent Povirk  writes:
> On Fri, Aug 14, 2009 at 4:55 AM, Alexandre Julliard wrote:
> > Much better this way, thanks. You should probably rename the test file
> > to converter.c or something like that though.
>
> That will be a problem when I want to use the test IWICBitmapSource
> with an encoder. Or should I just duplicate the code in another C
> file?

You can put it all in one file if you prefer. Still, testsrc.c isn't a
good name, you are not testing the testsrc bitmap, you are using it to
test other features. The file name should be based on what features you
are testing.