General Questions

[Scott Lindeneau]

I haven't had time to work on the AcceptEx patch since the last time I
submitted it to wine-patches. I still cannot reproduce the bug's
patchwatcher indicated but I had a few questions regarding the whole
process. When I finally get the patches to pass the patchwatcher
regression test, is there anyway for me to know what is going on with
the patch. Is Juilliard looking at them? Are they rejected? How long
does the patch review process take? Is it just Julliard doing them?

In regards to the AcceptEx patch in particular:
I know that there is extra attention paid to patches that modify the
wineserver. Should I spend extra time writing a discussion as to the
reasons why I felt the modifications needed to take place within the
wineserver?
With the AcceptEx patch I kind of just plowed ahead and did what I
thought needed to be done to make the functions work. Should I spend
more time discussing what I intend to do in the patches with someone
else before submitting them? Is someone willing to do this peer review
with me? (Note: I don't have a lot of time to program).

And lastly: Am I doing anything wrong (in general. not simply in
coding)? I don't know how these internet based, user based systems
work. I've never tried working with one before. Is there anything else
someone wants me to work on?

~Scott

[Juan Lang]

Hi Scott,
> When I finally get the patches to pass the patchwatcher regression test,
> is there anyway for me to know what is going on with the patch.
> Is Juilliard looking at them? Are they rejected? How long does the patch
> review process take? Is it just Julliard doing them?

These are some of the most asked questions around here.
1) Yes, Alexandre looks at all patches.
2) If a patch isn't committed right away and doesn't get any comment,
it's usually in the dreaded "not obviously correct" category.  This
usually means that something about it just doesn't "feel" right, so it
doesn't get accepted right away.  It's your job to convince Alexandre
that it's correct.  Test cases in the regression test suite go a long
way for this.  If you've gotten feedback on wine-devel and haven't
addressed it, your patch often will get ignored by AJ, as there's an
existing concern that's gone unaddressed by you.
3) Depends on the patch.  The review time is short for obvious
patches, and longer (though more than a week is atypical) for less
obvious ones.
4) Yes.

If you're unsure what's happening with your patches, and you've
addressed every concern brought up on wine-devel, try asking AJ on
irc.
--Juan