wineserver request size

[Eric Pouech]

how to handle large wineserver request structure ?

I've been working on adding the dwFillAttribute handling
to CreateProcess (and passing between parent and child)
while I was at it, I also added all the other fields 
(window geometry, console title/size...)
at the end the two requests used in the process
(new_process and init_process) are larger than the fixed
request_max_size structure (80 bytes would be needed)

so, what's the preferred way of handling this:
1) bump the request_max_size to the needed size (but all
   requests will be penalized about it)
2) remove the request_max_size (therefore aligning the
   size of the request on the one of the biggest available)
3) try to compress the structure fields (most of the data
   are 32 bits, whereas they would fit in 16 bit fields)
4) store the data above the 64 bytes into the variable part
   of the message (but that would break the current structure
   scheme)

A+

[Alexandre Julliard]

Eric Pouech  writes:
> so, what's the preferred way of handling this:
> - bump the request_max_size to the needed size (but all
> requests will be penalized about it)
> - remove the request_max_size (therefore aligning the
> size of the request on the one of the biggest available)
> - try to compress the structure fields (most of the data
> are 32 bits, whereas they would fit in 16 bit fields)
> - store the data above the 64 bytes into the variable part
> of the message (but that would break the current structure
> scheme)

Do 3) if possible, otherwise 4). The size limit is necessary to ensure
forward compatibility and should not be changed.

[Francois Gouget]

On Tue, 26 Feb 2002, Eric Pouech wrote:
> how to handle large wineserver request structure ?
>
> I've been working on adding the dwFillAttribute handling
> to CreateProcess (and passing between parent and child)
> while I was at it, I also added all the other fields
> (window geometry, console title/size...)
> at the end the two requests used in the process
> (new_process and init_process) are larger than the fixed
> request_max_size structure (80 bytes would be needed)

Hey, while you're at it, could you also pass the CommandLine around?
That would be one less recurring bug :-)

--
Francois Gouget         [e-mail]        http://fgouget.free.fr/
            "Lotto: A tax on people who are bad at math." -- unknown
          "Windows: Microsoft's tax on computer illiterates." -- WE7U