This seems to have been fixed by the recent changes to CreateProcess().
--- dlls/advapi32/tests/service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dlls/advapi32/tests/service.c b/dlls/advapi32/tests/service.c index aa9a69fed2..bd70ecaddf 100644 --- a/dlls/advapi32/tests/service.c +++ b/dlls/advapi32/tests/service.c @@ -1793,7 +1793,7 @@ static void test_wow64(void) ok(!!service, "Failed to create service, error %u.\n", GetLastError()); ret = StartServiceA(service, 0, NULL); ok(!ret, "Expected failure.\n"); - todo_wine ok(GetLastError() == ERROR_BAD_EXE_FORMAT, "Got error %u.\n", GetLastError()); + ok(GetLastError() == ERROR_BAD_EXE_FORMAT, "Got error %u.\n", GetLastError());
ret = DeleteService(service); ok(ret, "Failed to delete service, error %u.\n", GetLastError());
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=60120
Your paranoid android.
=== w1064v1809_ar (32 bit report) ===
advapi32: service.c:1724: Test failed: Expected a process id for this running service (sppsvc)
=== w1064v1809_he (32 bit report) ===
advapi32: service.c:2409: Test failed: Got wrong SleepEx result: 0 service.c:2410: Test failed: APC wasn't called service.c:2366: Test failed: Got wrong service state: 0x1 service.c:2368: Test failed: Got wrong notification triggered: 0x1 service.c:2357: Test failed: Got wrong service state: 0x4 service.c:2359: Test failed: Got wrong notification triggered: 0x8 service.c:2454: Test failed: APC should not have been called
=== w1064v1809_ja (32 bit report) ===
advapi32: service.c:1724: Test failed: Expected a process id for this running service (sppsvc)