wine / fontforge regression

[Molle Bestefich]

Hello,

This patch from Mar 9:
http://www.winehq.org/pipermail/wine-cvs/2006-March/021502.html

causes all applications run with Wine to continually emit:

err:font:ReadFontDir Can't open directory
  "/usr/local/bin/../lib/../share/wine/fonts/"

when fontforge isn't installed.

Also, take a look at the path above.
It's relative to '/usr/local/bin', ok - but why the double descend
into the parent directory?
The "../lib" seems completely redundant with the "../share" coming
right after it.

Regards

[Dmitry Timoshkov]

"Molle Bestefich"  wrote:
> This patch from Mar 9:
> http://www.winehq.org/pipermail/wine-cvs/2006-March/021502.html
>
> causes all applications run with Wine to continually emit:
>
> err:font:ReadFontDir Can't open directory
>   "/usr/local/bin/../lib/../share/wine/fonts/"
>
> when fontforge isn't installed.

Missing fontforge means that you don't have Wine builtin fonts which
leads to the above problems. The solution obviously is to install
fontforge or use a binary Wine package instead.
> Also, take a look at the path above.
> It's relative to '/usr/local/bin', ok - but why the double descend
> into the parent directory?
> The "../lib" seems completely redundant with the "../share" coming
> right after it.

That's a feature of a now fully relocatable Wine installation.

[Mike McCormack]

Dmitry Timoshkov wrote:
> Missing fontforge means that you don't have Wine builtin fonts which
> leads to the above problems. The solution obviously is to install
> fontforge or use a binary Wine package instead.

The problem is that it's not immediately obvious that FontForge is 
required, and most people don't have it installed.

How about we use one of the following solutions:

* put a warning about this in configure

* add the prebuild .ttf files to the source package and fall back to 
those if we don't have fontforge (not many people modify the .sfd files)

* write a wine utility to convert .sfd files to .ttf files  (difficult, 
as fontforge is not LGPL licensed, but the authour might give us 
permission).

Mike

[Vitaly Lipatov]

В сообщении от 3 апреля 2006 09:31 Mike McCormack написал(a):
...
> - add the prebuild .ttf files to the source package and fall back to
>
> those if we don't have fontforge (not many people modify the .sfd files)

I think it is optimal solution.
We can just pack .ttf files, it will not rebuild with fontforge if not 
changed.
I guess our goal is not "WINE from scratch" :)

[Dmitry Timoshkov]

"Mike McCormack"  wrote:
> The problem is that it's not immediately obvious that FontForge is 
> required, and most people don't have it installed.
>
> How about we use one of the following solutions:
> -
>
> put a warning about this in configure
> -
>
> add the prebuild .ttf files to the source package and fall back to
>
> those if we don't have fontforge (not many people modify the .sfd files)
> - write a wine utility to convert .sfd files to .ttf files  (difficult,
>
> as fontforge is not LGPL licensed, but the authour might give us 
> permission).

It's OK that most people don't have fontforge installed, that just means
that people who can't cope with compiling from source and can't satisfy
all the required dependencies to create a working binary shouldn't do it.
They need to use a prepackaged one from a confidential source who knows
what is needed and how to resolve the dependencies.

This is a developers list after all.

[Mike McCormack]

Dmitry Timoshkov wrote:
> It's OK that most people don't have fontforge installed, that just means
> that people who can't cope with compiling from source and can't satisfy
> all the required dependencies to create a working binary shouldn't do it.
> They need to use a prepackaged one from a confidential source who knows
> what is needed and how to resolve the dependencies.
>
> This is a developers list after all.

There's plenty of people who think they're qualified to compile from 
source (*cough* Gentoo *cough*), and don't realize that anything from 
missing dependencies to different compiler flags can cause trouble.

These people will file an endless stream of bug reports, and waste our 
time if we don't fix this somehow.

Mike

[Dmitry Timoshkov]

"Mike McCormack"  wrote:
> There's plenty of people who think they're qualified to compile from 
> source (*cough* Gentoo *cough*), and don't realize that anything from 
> missing dependencies to different compiler flags can cause trouble.

If they like spend their time looking at the compiler's output we can do
nothing to mend their minds.
> These people will file an endless stream of bug reports, and waste our 
> time if we don't fix this somehow.

I'd suggest to add freetype and fontforge to the optional support libraries
list in the README file and be done with this "regression".

[Tony Lambregts]

Dmitry Timoshkov wrote:
> "Mike McCormack"  wrote:
> > There's plenty of people who think they're qualified to compile from 
> > source (*cough* Gentoo *cough*), and don't realize that anything from 
> > missing dependencies to different compiler flags can cause trouble.
>
> If they like spend their time looking at the compiler's output we can do
> nothing to mend their minds.
> > These people will file an endless stream of bug reports, and waste our 
> > time if we don't fix this somehow.
>
> I'd suggest to add freetype and fontforge to the optional support libraries
> list in the README file and be done with this "regression".

<$0.02>
This seems like a hard dependancy to me if a user can't run winecfg 
without it.
</$0.02>

--

Tony Lambregts

[Dmitry Timoshkov]

"Tony Lambregts"  wrote:
> This seems like a hard dependancy to me if a user can't run winecfg 
> without it.

That's not true.

[Molle Bestefich]

> > err:font:ReadFontDir Can't open directory
> >   "/usr/local/bin/../lib/../share/wine/fonts/"
> >
> > when fontforge isn't installed.
>
> Missing fontforge means that you don't have Wine builtin fonts
> which leads to the above problems. The solution obviously is to
> install fontforge

Yes, as stated in my original report to wine-devel: "when fontforge
isn't installed".  And I can easily fix my problem up front by using
'grep -v ReadFontDir' or installing it.  That's not the point.

The point is that your coding style is bad here.

* It's a compile-time problem, but you ERR about it at run-time.

* You do not tell in your error message what the ground cause for the ERR is.

So much for the criticism; here's a suggestion.

First, being that FontForge is an _optional_ dependency, it's implied
that Wine works fine without it.  And so it does.  Therefore you should
not spam my console with ERR messages when Wine runs <anything>.  Please
make it stop doing that (again)?  This is the "regression" part by the way.

Second, at the end of the ./configure process, warn the compilee that
feature X, Y and Z has been disabled because this-and-that dependency was
not fulfilled.  "Your fonts will look weird because there was no FontForge"
or something akin would be a good hint delivered at the right time.
> It's OK that most people don't have fontforge installed, that just
> means that people who can't cope with compiling from source [...]
> shouldn't do it.

I find that arrogant.  You're saying that anyone who doesn't know
about the intimacies of how Wine handles fonts should stay away
from compiling it in the first place.

- "Don't even mess with the code if you don't know how it's font
    rendering works.  I'm not even kidding!"

- "But I wan't to learn to code Wine and to contribute..."

- "F*** off!  Learn somewhere else, come back when yer' grown-up."

If that's the official CW or WINE-DEVEL consensus, then ok..
> > Also, take a look at the path above.
> > It's relative to '/usr/local/bin', ok - but why the double descend
> > into the parent directory?
> > The "../lib" seems completely redundant with the "../share" coming
> > right after it.
>
> That's a feature of a now fully relocatable Wine installation.

I know.  You missed the point.

We'll just try again:
Why        "/usr/local/bin/../lib/../share/wine/fonts/"
instead of "/usr/local/bin/../share/wine/fonts/"

Might this be a bug?

[Mike McCormack]

Molle Bestefich wrote:
> -
>
> It's a compile-time problem, but you ERR about it at run-time.
> -
>
> You do not tell in your error message what the ground cause for the ERR is.

Some patches have been applied to Wine that should improve the 
situation.  We now only warn at configure time.

Mike

[Alexandre Julliard]

"Molle Bestefich"  writes:
> We'll just try again:
> Why        "/usr/local/bin/../lib/../share/wine/fonts/"
> instead of "/usr/local/bin/../share/wine/fonts/"
>
> Might this be a bug?

Nope.

[Tom Spear]

On 4/4/06, Alexandre Julliard  wrote:
> "Molle Bestefich"  writes:
> > We'll just try again:
> > Why        "/usr/local/bin/../lib/../share/wine/fonts/"
> > instead of "/usr/local/bin/../share/wine/fonts/"
> >
> > Might this be a bug?
>
> Nope.
>
> --
> Alexandre Julliard
> [e-mail]

What it does is check /usr/local/bin/wine/fonts and when it doesn't find the
fonts there, it backs up and moves to /usr/local/lib/wine/fonts, when it
doesn't find them there, it backs up again and moves to
/usr/local/share/wine/fonts.  When it doesn't find them there either, it
fails..  That is why they say it is fully relocatable.. (AFAIK) You can move
the entire install out of the bindir and wine won't die...

Tom