Re: d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

[Henri Verbeet]

On 24 August 2010 05:05, Misha Koshelev  wrote:
> -
>    elements[idx].Stream = 0xFF;
> -
>    elements[idx].Offset = D3DXGetDeclVertexSize(elements, 0);
> -
>    elements[idx].Stream = 0;

That's ugly.
> - memcpy(Declaration, elements, size * sizeof(D3DVERTEXELEMENT9));

That's unnecessary.

d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

[misha680]

Henri Verbeet wrote:
> On 24 August 2010 05:05, Misha Koshelev  wrote:
> > -
> >    elements[idx].Stream = 0xFF;
> > -
> >    elements[idx].Offset = D3DXGetDeclVertexSize(elements, 0);
> > -
> >    elements[idx].Stream = 0;
>
> That's ugly.
> > - memcpy(Declaration, elements, size * sizeof(D3DVERTEXELEMENT9));
>
> That's unnecessary.

Thanks, I noticed your patches here:
http://source.winehq.org/patches/data/65330
http://source.winehq.org/patches/data/65331
http://source.winehq.org/patches/data/65331

What do you think about this one on top of those? I will wait to send to
wine-patches until your patches have been committed.
http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Implement-D3DXDec...
0004-d3dx9-Implement-D3DXDeclaratorFromFVF.txt

Thank you
Misha

d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

[Henri Verbeet]

On 25 August 2010 04:04, misha680  wrote:
> What do you think about this one on top of those? I will wait to send to
> wine-patches until your patches have been committed.
> http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Implement-D3DXDec...

Still not quite right, I'm afraid, although it's a bit closer.
However, as mentioned in
http://www.winehq.org/pipermail/wine-devel/2010-August/086112.html,
since this is about the tenth version of D3DXDeclaratorFromFVF() I'm
seeing (not counting the ones in d3d9 and wined3d...), I went ahead
and just implemented it myself. The patch attached to that mail is the
initial untested version. The patch attached to this mail is what I
think it should look like after doing some tests. I'll probably send
it in tomorrow.

d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

[Misha Koshelev]

On Wed, 2010-08-25 at 12:28 +0200, Henri Verbeet wrote:
> On 25 August 2010 04:04, misha680  wrote:
> > What do you think about this one on top of those? I will wait to send to
> > wine-patches until your patches have been committed.
> > http://wine.1045685.n5.nabble.com/file/n2652101/0004-d3dx9-Implement-D3DXDec...
>
> Still not quite right, I'm afraid, although it's a bit closer.
> However, as mentioned in
> http://www.winehq.org/pipermail/wine-devel/2010-August/086112.html,
> since this is about the tenth version of D3DXDeclaratorFromFVF() I'm
> seeing (not counting the ones in d3d9 and wined3d...), I went ahead
> and just implemented it myself. The patch attached to that mail is the
> initial untested version. The patch attached to this mail is what I
> think it should look like after doing some tests. I'll probably send
> it in tomorrow.

Thank you so much.

My apologies - for some reason I got confused and thought that the
patches in

http://wine.1045685.n5.nabble.com/Re-d3dx9-Implement-D3DXDeclaratorFromFVF-t...

for some reason were from Paulo Lesgaz.

Thank you for your help with this!

Misha

d3dx9: Implement D3DXDeclaratorFromFVF. (try 2)

[Henri Verbeet]

On 25 August 2010 14:31, Misha Koshelev  wrote:
> for some reason were from Paulo Lesgaz.

For what it's worth, "Paulo Lesgaz" is an (obvious) pseudonym, as is
"Jérémie Lapurée". See e.g. http://fr.wikipedia.org/wiki/Joe_Bar_Team
for reference.