Re: ws2_32: Handle the formatting of IPV6 addresses and use inet_ntop function

[Juan Lang]

Hi Jeff,

I have a competing version of a similar patch that I was going to send
in.  Ordinarily I'd defer to the first poster rule, but in this case
I'd rather mine were used.  The difference is, you use the ternary
comparison operator:

+                 (((const struct WS_sockaddr_in *)a)->sin_family == AF_INET) ?
+                 (void *)&((struct WS_sockaddr_in *)a)->sin_addr :
+                 ((struct WS_sockaddr_in6 *)a)->sin6_addr.WS_s6_addr,

This makes the expression rather long, and also makes it hard to
extend beyond two address families.  ws2_32 also supports IPX, and
with any luck it'll soon support IrDA.

I'll send mine in shortly, and you can complain if you like :)
--Juan

ws2_32: Handle the formatting of IPV6 addresses and use inet_ntop function

[Jeff Latimer]

On 29/07/09 01:21, Juan Lang wrote:
> This makes the expression rather long, and also makes it hard to
> extend beyond two address families.  ws2_32 also supports IPX, and
> with any luck it'll soon support IrDA.
>
> I'll send mine in shortly, and you can complain if you like :)

That's ok.  I had a version that used a case statement but I tried to 
make it more compact as AJ seems to favour that more.

WINE and iTunes

[Martin Packer]

Where are we with supporting iTunes?

I've not seen anyone recently say it works. Installing doesn't seem to 
work on 1.1.26.

I'd've thought it would be a popular package to support.

Just wondering where we are with it. (And whether help is needed.)

Thanks, Martin

Martin Packer
Performance Consultant
IBM United Kingdom Ltd
[phone]
[phone]

email: [e-mail]

Twitter ID: MartinPacker

"They're figuring out that collaboration isn't a productivity hit, it 
makes them smarter." Sam Palmisano on BlogCentral, 26 November 2008

Unless stated otherwise above:
IBM United Kingdom Limited - Registered in England and Wales with number 
741598. 
Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

WINE and iTunes

[Roderick Colenbrander]

According to appdb there is indeed some small installer regressions
and for that some hack is posted there (see
http://appdb.winehq.org/objectManager.php?sClass=version&iId=14793).
Using this hack the program apparently installs and runs. The main
limitation is that we don't have USB support for ipod/iphone
synchronization. Maarten Lankhorst worked a bit on that last year but
his work needs to be finished and cleaned up. Fixing the msi issue
might be easy but it requires writing of a small msi test case I
think.

Roderick

On Wed, Jul 29, 2009 at 12:47 PM, Martin Packer wrote:
> Where are we with supporting iTunes?
>
> I've not seen anyone recently say it works. Installing doesn't seem to work
> on 1.1.26.
>
> I'd've thought it would be a popular package to support.
>
> Just wondering where we are with it. (And whether help is needed.)
>
> Thanks, Martin
>
> Martin Packer
> Performance Consultant
> IBM United Kingdom Ltd
> [phone]
> [phone]
>
> email: [e-mail]
>
> Twitter ID: MartinPacker
>
> "They're figuring out that collaboration isn't a productivity hit, it makes
> them smarter." Sam Palmisano on BlogCentral, 26 November 2008
>
> Unless stated otherwise above:
> IBM United Kingdom Limited - Registered in England and Wales with number
> 741598.
> Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU

WINE and iTunes

[Reece Dunn]

2009/7/29 Roderick Colenbrander :
> According to appdb there is indeed some small installer regressions
> and for that some hack is posted there (see
> http://appdb.winehq.org/objectManager.php?sClass=version&iId=14793).
> Using this hack the program apparently installs and runs. The main
> limitation is that we don't have USB support for ipod/iphone
> synchronization. Maarten Lankhorst worked a bit on that last year but
> his work needs to be finished and cleaned up. Fixing the msi issue
> might be easy but it requires writing of a small msi test case I
> think.

It is failing because the installer is running a custom action that is
trying to update the Windows firewall configuration (see
http://bugs.winehq.org/show_bug.cgi?id=15533). So this isn't an error
specific to MSI -- MSI is doing the right thing here.

Particularly:

-------  Comment #10 From  Reece Dunn   2009-01-06 11:30:58  -------

MSI error 1603 is a generic "something went wrong" error.

WiX is an open source MSI installer creator by Microsoft, available on
sourceforge. Using the power of Google, I suspect that this functionality is
mentioned in
http://www.joyofsetup.com/2008/05/17/new-wix-feature-firewall-extension/.

It looks like iTunes is trying to query the Windows Firewall services and is
failing because Wine does not implement this interface yet (bug 15563, bug
12876 and others).

Do you know if the logs mention trying to CoCreate
{304ce942-6e39-40d8-943a-b913c40c9cd4} (CSLID_NetFwMgr)? If it does, then this
seems the most likely scenario.

------- Comment #11 From Cheba 2009-01-07 17:04:20 -------

(In reply to comment #10)
> Do you know if the logs mention trying to CoCreate
> {304ce942-6e39-40d8-943a-b913c40c9cd4} (CSLID_NetFwMgr)? If it does, then this
> seems the most likely scenario.

Yes it tries. I see this lines in terminal:

err:ole:CoGetClassObject class {304ce942-6e39-40d8-943a-b913c40c9cd4} not
registered
err:ole:CoGetClassObject no class object {304ce942-6e39-40d8-943a-b913c40c9cd4}
could be created for context 0x1

------

NOTE: It appears that other applications are failing for similar
reasons (lack of firewall API implementation in Wine). AFAIU, the API
implementation does not actually need to do anything, it just needs to
be sufficiently stubbed to allow the applications that are using it to
succeed.

- Reece

WINE and iTunes

[Stephen Eilert]

I have seen patches in that bug report to add the firewall stubs. Is there
any problem with those patches?

Or, more to the point, is there any way I could contribute? I am not too
familiar with the firewall API or Marteen's work, but I am sure that can be
mitigated with some study :)

I might have found my personal Wine itch to scratch :)

--Stephen

programmer, n:
       A red eyed, mumbling mammal capable of conversing with inanimate
monsters.

On Wed, Jul 29, 2009 at 9:21 AM, Reece Dunn  wrote:
> 2009/7/29 Roderick Colenbrander :
> > According to appdb there is indeed some small installer regressions
> > and for that some hack is posted there (see
> > http://appdb.winehq.org/objectManager.php?sClass=version&iId=14793).
> > Using this hack the program apparently installs and runs. The main
> > limitation is that we don't have USB support for ipod/iphone
> > synchronization. Maarten Lankhorst worked a bit on that last year but
> > his work needs to be finished and cleaned up. Fixing the msi issue
> > might be easy but it requires writing of a small msi test case I
> > think.
>
> It is failing because the installer is running a custom action that is
> trying to update the Windows firewall configuration (see
> http://bugs.winehq.org/show_bug.cgi?id=15533). So this isn't an error
> specific to MSI -- MSI is doing the right thing here.
>
> Particularly:
>
> -------  Comment #10 From  Reece Dunn   2009-01-06 11:30:58  -------
>
> MSI error 1603 is a generic "something went wrong" error.
>
> WiX is an open source MSI installer creator by Microsoft, available on
> sourceforge. Using the power of Google, I suspect that this functionality
> is
> mentioned in
> http://www.joyofsetup.com/2008/05/17/new-wix-feature-firewall-extension/.
>
> It looks like iTunes is trying to query the Windows Firewall services and
> is
> failing because Wine does not implement this interface yet (bug 15563, bug
> 12876 and others).
>
> Do you know if the logs mention trying to CoCreate
> {304ce942-6e39-40d8-943a-b913c40c9cd4} (CSLID_NetFwMgr)? If it does, then
> this
> seems the most likely scenario.
>
> ------- Comment #11 From Cheba 2009-01-07 17:04:20 -------
>
> (In reply to comment #10)
> > Do you know if the logs mention trying to CoCreate
> > {304ce942-6e39-40d8-943a-b913c40c9cd4} (CSLID_NetFwMgr)? If it does, then
>
> this
> > seems the most likely scenario.
>
> Yes it tries. I see this lines in terminal:
>
> err:ole:CoGetClassObject class {304ce942-6e39-40d8-943a-b913c40c9cd4} not
> registered
> err:ole:CoGetClassObject no class object
> {304ce942-6e39-40d8-943a-b913c40c9cd4}
> could be created for context 0x1
>
> NOTE: It appears that other applications are failing for similar
> reasons (lack of firewall API implementation in Wine). AFAIU, the API
> implementation does not actually need to do anything, it just needs to
> be sufficiently stubbed to allow the applications that are using it to
> succeed.
> - Reece

WINE and iTunes

[Nikolay Sivov]

Stephen Eilert wrote:
> I have seen patches in that bug report to add the firewall stubs. Is 
> there any problem with those patches?

http://www.winehq.org/pipermail/wine-devel/2009-July/077523.html

This explains it. Next commits should start on Monday 3rd.
> Or, more to the point, is there any way I could contribute? I am not 
> too familiar with the firewall API or Marteen's work, but I am sure 
> that can be mitigated with some study :)

Looks like in this particular iTunes case stub is enough. It needed only 
to make msi installation procedure happy obtaining
firewall api interfaces.

Anyway contributors are more than welcome here. Just start with 
developer section of WinHQ.org and choose area you're interested in.
Feel free to ask here where help is needed if in doubt.

Regards.
> I might have found my personal Wine itch to scratch :)
>
> --Stephen
>
> programmer, n:
>        A red eyed, mumbling mammal capable of conversing with 
> inanimate monsters.