Re: [PATCH] cmd: Add help info for xcopy

[Frédéric Delanoy]

On Fri, Sep 9, 2011 at 09:16, Christian Costa  wrote:
> --- a/programs/cmd/builtins.c
> +++ b/programs/cmd/builtins.c
> @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'};
>  static const WCHAR nullW[] = {'\0'};
>
> const WCHAR externals[][10] = {
> - {'A','T','T','R','I','B','\0'}
> - {'A','T','T','R','I','B','\0'},
> - {'X','C','O','P','Y','\0'}

Patch is OK, but for consistency, shouldn't the externals be put at
the start of wcmdmain.c, just after the inbuilt[][]10]?
This way, you could see directly which command is built-in, and which
is external.

Frédéric

[PATCH] cmd: Add help info for xcopy

[Christian Costa]

Makes sense. I will send another patch once it is commited.

Christian
> Message du 09/09/11 09:53
> De : "Frédéric Delanoy" 
> A : [e-mail]
> Copie à : "Christian Costa" 
> Objet : Re: [PATCH] cmd: Add help info for xcopy
>
> On Fri, Sep 9, 2011 at 09:16, Christian Costa wrote:
>
> --- a/programs/cmd/builtins.c
> +++ b/programs/cmd/builtins.c
> @@ -68,7 +68,8 @@ static const WCHAR parmNoY[] = {'/','-','Y','\0'};
>  static const WCHAR nullW[] = {'\0'};
>
> const WCHAR externals[][10] = {
> - {'A','T','T','R','I','B','\0'}
> - {'A','T','T','R','I','B','\0'},
> - {'X','C','O','P','Y','\0'}

Patch is OK, but for consistency, shouldn't the externals be put at
the start of wcmdmain.c, just after the inbuilt[][]10]?
This way, you could see directly which command is built-in, and which
is external.

Frédéric

[PATCH] cmd: Add help info for xcopy

[Octavian Voicu]

2011/9/9 Frédéric Delanoy
> Patch is OK, but for consistency, shouldn't the externals be put at
> the start of wcmdmain.c, just after the inbuilt[][]10]?
> This way, you could see directly which command is built-in, and which
> is external.

+ make it static const, since it's not used outside of builtins.c.

Octavian

[PATCH] cmd: Add help info for xcopy

[Christian Costa]

On 10/09/2011 00:56, Octavian Voicu wrote:
> 2011/9/9 Frédéric Delanoy <[e-mail] 
> >
> Patch is OK, but for consistency, shouldn't the externals be put at
> the start of wcmdmain.c, just after the inbuilt[][]10]?
> This way, you could see directly which command is built-in, and which
> is external.
>
>
> - make it static const, since it's not used outside of builtins.c.
>
> Octavian

That's true in that case but the list will go to another file. I sent a 
patch for that.

Christian