On Tue, 08 Sep 2015 16:45:18 +0300, Nikolay Sivov wrote:
--- a/dlls/oledlg/oledlg.rc +++ b/dlls/oledlg/oledlg.rc @@ -30,7 +30,9 @@ STRINGTABLE IDS_NOTOLEMOD "File does not appear to be a valid OLE module. Unable to register OLE control." IDS_NOTOLEMODCAPTION "Add Control" IDS_VERBMENU_OBJECT "&Object"
- IDS_VERBMENU_OBJECT_WITH_NAME "%s &Object" IDS_VERBMENU_CONVERT "&Convert..."
- IDS_VERBMENU_SINGLEVERB_OBJECT "%1 %2 &Object"
This patch has been commited, but you may want to use %1, instead of %s, for IDS_VERBMENU_OBJECT_WITH_NAME.
Akihiro Sagawa
On 10.09.2015 15:27, Akihiro Sagawa wrote:
On Tue, 08 Sep 2015 16:45:18 +0300, Nikolay Sivov wrote:
--- a/dlls/oledlg/oledlg.rc +++ b/dlls/oledlg/oledlg.rc @@ -30,7 +30,9 @@ STRINGTABLE IDS_NOTOLEMOD "File does not appear to be a valid OLE module. Unable to register OLE control." IDS_NOTOLEMODCAPTION "Add Control" IDS_VERBMENU_OBJECT "&Object"
- IDS_VERBMENU_OBJECT_WITH_NAME "%s &Object" IDS_VERBMENU_CONVERT "&Convert..."
- IDS_VERBMENU_SINGLEVERB_OBJECT "%1 %2 &Object"
This patch has been commited, but you may want to use %1, instead of %s, for IDS_VERBMENU_OBJECT_WITH_NAME.
Do you mean FormatMessage can't handle %s format?
Akihiro Sagawa
On Thu, 10 Sep 2015 15:32:03 +0300, Nikolay Sivov wrote:
- IDS_VERBMENU_OBJECT_WITH_NAME "%s &Object" IDS_VERBMENU_CONVERT "&Convert..."
- IDS_VERBMENU_SINGLEVERB_OBJECT "%1 %2 &Object"
This patch has been commited, but you may want to use %1, instead of %s, for IDS_VERBMENU_OBJECT_WITH_NAME.
Do you mean FormatMessage can't handle %s format?
Yes, FormatMessage has a different notation like %1!s! or just %1. For details, please see our implementation[1] or MSDN documents[2].
[1] https://source.winehq.org/source/dlls/kernel32/format_msg.c?!v=wine-1.7.51#0... [2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms679351%28v=vs.85%...
On 10.09.2015 18:31, Akihiro Sagawa wrote:
On Thu, 10 Sep 2015 15:32:03 +0300, Nikolay Sivov wrote:
- IDS_VERBMENU_OBJECT_WITH_NAME "%s &Object" IDS_VERBMENU_CONVERT "&Convert..."
- IDS_VERBMENU_SINGLEVERB_OBJECT "%1 %2 &Object"
This patch has been commited, but you may want to use %1, instead of %s, for IDS_VERBMENU_OBJECT_WITH_NAME.
Do you mean FormatMessage can't handle %s format?
Yes, FormatMessage has a different notation like %1!s! or just %1. For details, please see our implementation[1] or MSDN documents[2].
Thanks, I missed that, will send a fix.
[1] https://source.winehq.org/source/dlls/kernel32/format_msg.c?!v=wine-1.7.51#0... [2] https://msdn.microsoft.com/en-us/library/windows/desktop/ms679351%28v=vs.85%...
-
Akihiro Sagawa -
Nikolay Sivov