On Sunday 29 February 2004 20:49, Juan Lang wrote:
Shouldn't wininet build on ws2_32 and thus compile? I think it should be investigated...
wininet currently depends on OpenSSL and BSD (unix) sockets. I think the way OpenSSL is being used makes it rather hard to use ws2_32 instead, but if someone wants to take that on that would help. I'm trying to implement SSL in secur32.dll so wininet can use this, but it will take me a while (it's rather large). Helpers welcome :)
I can fix up vnb.vxd, it really should build on MinGW, whether or not it's useful to do so. I'll send a patch shortly.
If I include winsock2.h, get rid of the sys/socket.h, netinet/in.h and arpa/inet.h includes and additionally link to ws2_32 it builds on MinGW as well as Wine.
Hans, why didn't wsock32 build? It looks like configure should protect you against missing headers and whatnot; it mostly forwards to iphlpapi and ws2_32.
It's missing some constants:
../../../wine/dlls/wsock32/protocol.c:144: `SOCK_STREAM' undeclared (first use in this function)
../../../wine/dlls/wsock32/protocol.c:155: `SOCK_DGRAM' undeclared (first use in this function)
These are in winsock.h but protocol.c only includes winsock2.h When I change the include to winsock.h I get:
../../../wine/include/winsock.h:25:4: #error Please use Winsock2 in Wine
winsock2.h says:
FIXME: Still missing required Winsock 2 definitions.
MinGW and MSVC versions of winsock2.h have the defines, so I guess we need to add them. Attached patch does so.
-Hans
Changelog: add protocol type constants.
--- Hans Leidekker hans@it.vu.nl wrote:
If I include winsock2.h, get rid of the sys/socket.h, netinet/in.h and arpa/inet.h includes and additionally link to ws2_32 it builds on MinGW as well as Wine.
You have to link to ws2_32? That's interesting, I didn't. I submitted a patch, minus that bit.
Hans, why didn't wsock32 build?
It's missing some constants:
(snip...)
winsock2.h says:
FIXME: Still missing required Winsock 2 definitions.
MinGW and MSVC versions of winsock2.h have the defines, so I guess we need to add them. Attached patch does so.
Could you submit to wine-patches? Thanks! --Juan
__________________________________ Do you Yahoo!? Get better spam protection with Yahoo! Mail. http://antispam.yahoo.com/tools
On Monday 01 March 2004 18:55, Juan Lang wrote:
additionally link to ws2_32 it builds on MinGW as well as Wine.
You have to link to ws2_32? That's interesting, I didn't. I submitted a patch, minus that bit.
Yes you need to, I have tested this. You don't need it on Wine because there you somehow get inet_addr indirectly, but on MinGW (and MSVC) you sure need it otherwise it won't build.
MinGW and MSVC versions of winsock2.h have the defines, so I guess we need to add them. Attached patch does so.
Could you submit to wine-patches? Thanks!
I intended to do so but I addressed it to wine-devel twice, so here it is again. This fixes cross compilation of wsock32.
-Hans
Changelog: add protocol type constants.