Re: user32: Fix Jittery Mouse movement

[Vitaliy Margolen]

On 04/22/2011 02:06 PM, EG Galano wrote:
> This fixes jittery mouse movement in Combat Arms. This was introduced
> in commit 79c2e55b5a6331d15788f65a929e9e002c2f8b05
>
> This is likely the same issue discussed here but I don't have a copy
> to test: http://forum.winehq.org/viewtopic.php?t=11759&sid=9d9518057d4c0ef51be8c3...
> - if (ret && (prev_x != new_x || prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y );
> - if (ret && (prev_x != new_x && prev_y != new_y)) USER_Driver->pSetCursorPos( new_x, new_y );

Obviously this is wrong. Something else is at fault here.

Vitaliy.

user32: Fix Jittery Mouse movement

[EG Galano]

On Fri, Apr 22, 2011 at 6:10 PM, Vitaliy Margolen
 wrote:
> On 04/22/2011 02:06 PM, EG Galano wrote:
> > This fixes jittery mouse movement in Combat Arms. This was introduced
> > in commit 79c2e55b5a6331d15788f65a929e9e002c2f8b05
> >
> > This is likely the same issue discussed here but I don't have a copy
> > to test:
> > http://forum.winehq.org/viewtopic.php?t=11759&sid=9d9518057d4c0ef51be8c3...
> > - if (ret && (prev_x != new_x || prev_y != new_y))
> >
> > USER_Driver->pSetCursorPos( new_x, new_y );
> > - if (ret && (prev_x != new_x && prev_y != new_y))
> >
> > USER_Driver->pSetCursorPos( new_x, new_y );
>
> Obviously this is wrong. Something else is at fault here.

Right, my mistake. Got confused for a second there. Trying to track
down the true culprit now.

-EG