That commit regressed at least 3 applications: 48375 48388 48411 and I won't have time to investigate and fix what is wrong before Wine 5.0 is released.
I also believe our time now is better spent on cleaning up the winsock tests and then doing these riskier changes later on, when they can be tested properly.
Signed-off-by: Damjan Jovanovic damjan.jov@gmail.com --- dlls/ws2_32/tests/sock.c | 5 +++-- server/sock.c | 2 +- 2 files changed, 4 insertions(+), 3 deletions(-)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=62867
Your paranoid android.
=== debian10 (32 bit Japanese:Japan report) ===
ws2_32: sock.c:3057: Test succeeded inside todo block: Test[1]: expected 0, got 0 sock.c:3057: Test succeeded inside todo block: Test[2]: expected 0, got 0 sock.c:3057: Test succeeded inside todo block: Test[1]: expected 0, got 0
=== debian10 (32 bit Chinese:China report) ===
ws2_32: sock.c:3057: Test succeeded inside todo block: Test[2]: expected 0, got 0
=== debian10 (32 bit WoW report) ===
ws2_32: sock.c:3057: Test succeeded inside todo block: Test[1]: expected 0, got 0
-
Damjan Jovanovic -
Marvin