Re: [PATCH] [DbgHelp]: implemented 64 bit versions of EnumerateLoadedModules

[Alexandre Julliard]

Eric Pouech  writes:
> +BOOL  WINAPI EnumerateLoadedModulesW64(HANDLE hProcess,
> -
>                                   PENUMLOADED_MODULES_CALLBACKW64 E=
>
> numLoadedModulesCallback,
> -
>                                   PVOID UserContext)
>
> +{
> - struct enum_load_mod64_W64  x;
> -
> - x.cb =3D EnumLoadedModulesCallback;
> - x.user =3D UserContext;
> -
> - return EnumerateLoadedModules64(hProcess, enum_load_mod64_W64, &x);

You should make the A function call the W one, not the other way
around.

[PATCH] [DbgHelp]: implemented 64 bit versions of EnumerateLoadedModules

[Eric Pouech]

> You should make the A function call the W one, not the other way
> around.

in theory yes
in practice, it would require rewriting all module storage, lookup... 
with unicode strings which is on my todo list, but with a very low 
priority. BTW, all the module handling code in dbghelp is already 
working this way (W calling A). So, I think it's acceptable the way the 
patch is coded.

A+