Re: [PATCH 1/3] msctf: Add ITfThreadMgrEx stub.

[Alistair Leslie-Hughes]

Hi Matteo,

On 29/10/15 08:27, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni
>
> This avoids a crash on exit with World of Warships when the OS version
> is set to Windows 7.
>
> dlls/msctf/threadmgr.c | 145 ++++++++++++++++++++++++++++---------------------
>   include/msctf.idl      |  14 +++++
>   2 files changed, 96 insertions(+), 63 deletions(-)

Can you please provide tests?

Best Regards
  Alistair Leslie-Hughes

[PATCH 1/3] msctf: Add ITfThreadMgrEx stub.

[Matteo Bruni]

2015-10-29 8:01 GMT+01:00 Alistair Leslie-Hughes :
> Hi Matteo,
>
> On 29/10/15 08:27, Matteo Bruni wrote:
> > Signed-off-by: Matteo Bruni
> >
> > This avoids a crash on exit with World of Warships when the OS version
> > is set to Windows 7.
> >
> > dlls/msctf/threadmgr.c | 145
> > ++++++++++++++++++++++++++++---------------------
> >   include/msctf.idl      |  14 +++++
> >   2 files changed, 96 insertions(+), 63 deletions(-)
>
> Can you please provide tests?
>
> Best Regards
>  Alistair Leslie-Hughes

There isn't much to test at this point. The biggest regression danger
with these two patches is that some application now might start using
those new interfaces and crash. If we get any bug report I'm obviously
going to work to implement the stubs as necessary.