The attached patch should fix the crash in bug #6120, but I'm afraid I don't understand enough to know if the patch is correct or not. The code that the patch removes was setting the client site pointer to NULL. A later dereference on that pointer causes the crash. I guess I don't understand why the client site pointer is being explicitly set to NULL. Shouldn't Release handle that when the reference count reaches zero?
- Allan
Hi,
I dont know about ole32 stuff. I think we should not remove the stuff, you have just removed. rather it would be better if there is null check for it, and decrease reference count.
Thanks, VJ PS: I really dont know about ole32 stuff.
On 11/3/07, Allan Tong actong88@gmail.com wrote:
The attached patch should fix the crash in bug #6120, but I'm afraid I don't understand enough to know if the patch is correct or not. The code that the patch removes was setting the client site pointer to NULL. A later dereference on that pointer causes the crash. I guess I don't understand why the client site pointer is being explicitly set to NULL. Shouldn't Release handle that when the reference count reaches zero?
- Allan
-
Allan Tong -
Vijay Kiran Kamuju