Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11540
Your paranoid android.
=== w2000pro (32 bit job) === job.c:300: Test failed: Expected exit_code to be 1816 (ERROR_NOT_ENOUGH_QUOTA) is 0
=== wxppro (32 bit job) === job.c:300: Test failed: Expected exit_code to be 1816 (ERROR_NOT_ENOUGH_QUOTA) is 0
I can't seem to reproduce these failures
On Sat, 2015-02-14 at 19:26 -0600, Marvin wrote:
Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=11540
Your paranoid android.
=== w2000pro (32 bit job) === job.c:300: Test failed: Expected exit_code to be 1816 (ERROR_NOT_ENOUGH_QUOTA) is 0
=== wxppro (32 bit job) === job.c:300: Test failed: Expected exit_code to be 1816 (ERROR_NOT_ENOUGH_QUOTA) is 0
It looks like race condition. You create two processes and expect the second one to hit the limit but it seems to me that it could be the first as well.
It's not that, ERROR_NOT_ENOUGH_QUOTA is returned from AssignProcessToJobObject, but the process is randomly killed with an exit code of 0 instead.
And the other process is killed with 0 otherwise winetest_wait_child_process would complain, unless TerminateProcess overwrites the exiting exit code.
On Mon, 2015-02-16 at 10:40 +0100, Hans Leidekker wrote:
It looks like race condition. You create two processes and expect the second one to hit the limit but it seems to me that it could be the first as well.
-
Andrew Cook -
Hans Leidekker -
Marvin