Re: [PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

[Nikolay Sivov]

On 1/8/2013 22:19, Patrick Rudolph wrote:
> - BOOL progressRoutine_enabled = progressRoutine != 0;

Why do you need this? You could always check for callback pointer directly.

[PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

[Patrick Rudolph]

Am 2013-01-08 20:41, schrieb Nikolay Sivov:
> On 1/8/2013 22:19, Patrick Rudolph wrote:
> > - BOOL progressRoutine_enabled = progressRoutine != 0;
>
> Why do you need this? You could always check for callback pointer 
> directly.

This is necessary because the called progressRoutine can return 
PROGRESS_QUIET any time. The copy operation continues, but stops 
invoking progressRoutine to report progress.

[PATCH 2/4] kernel32/path : implement copyfileexW progressroutine callback

[Nikolay Sivov]

On 1/9/2013 01:12, Patrick Rudolph wrote:
> Am 2013-01-08 20:41, schrieb Nikolay Sivov:
> > On 1/8/2013 22:19, Patrick Rudolph wrote:
> > > - BOOL progressRoutine_enabled = progressRoutine != 0;
> >
> > Why do you need this? You could always check for callback pointer 
> > directly.
>
> This is necessary because the called progressRoutine can return 
> PROGRESS_QUIET any time. The copy operation continues, but stops 
> invoking progressRoutine to report progress.

Sure, so you can just reset progressRoutine to NULL in this case and do 
not call it after.