On Thu, Jan 29, 2015 at 9:19 AM, Monster manuiglesias96@yahoo.es wrote:
@@ -220,7 +220,10 @@ BOOL wined3d_resource_allocate_sysmem(struct wined3d_resource *resource) SIZE_T align = RESOURCE_ALIGNMENT - 1 + sizeof(*p); void *mem;
- if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY,
resource->size + align)))
- UINT size = resource->size;
- if (resource->width <= 128 && resource->height <= 128)
- size *= 2;
- if (!(mem = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, size +
align))) return FALSE; p = (void **)(((ULONG_PTR)mem + align) & ~(RESOURCE_ALIGNMENT - 1)) - 1;
Please use your real name when sending patches.
You'll also need to use `git format-patch` to generate your diffs, and `git send-email` so that your mail client doesn't add extra line breaks like it did, and linking to the bug report that this patch is supposed to fix is always a good idea. Also, Alexandre is going to expect you to include some new, relevant unit tests in the patch.
-Alex
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
While the patch style hints are right, the more fundamental issue is that this patch is a game-specific hack that happens to work by chance rather than fix the real issue. As such it isn't acceptable to Wine.
The proper fix is to move memory allocation into the container. This is not a simple task though.
Am 2015-01-30 um 00:45 schrieb Alex Henrie:
You'll also need to use `git format-patch` to generate your diffs, and `git send-email` so that your mail client doesn't add extra line breaks like it did, and linking to the bug report that this patch is supposed to fix is always a good idea. Also, Alexandre is going to expect you to include some new, relevant unit tests in the patch.
-Alex
-
Alex Henrie -
Austin English -
Stefan Dösinger