Re: ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.

[Marvin]

Hi,

While running your changed tests on Windows, I think I found new failures.
Being a bot and all I'm not very good at pattern recognition, so I might be
wrong, but could you please double-check?
Full results can be found at
https://testbot.winehq.org/JobDetails.pl?Key=23462

Your paranoid android.

=== w864 (32 bit ddraw7) ===
ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

=== w1064 (32 bit ddraw7) ===
ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).
ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

=== w1064 (64 bit ddraw7) ===
ddraw7.c:2270: Test failed: Expected (0,0)-(512,384), got (0,0)-(1024,768).
ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.

[Stefan Dösinger]

> === w864 (32 bit ddraw7) ===
> ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.

Fwiw, this is my recently added test. I'll look at it on the weekend.

ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.

[Henri Verbeet]

On 8 June 2016 at 23:48, Stefan Dösinger  wrote:
> > === w864 (32 bit ddraw7) ===
> > ddraw7.c:7911: Test failed: Got unexpected P8 color key blit result.
>
> Fwiw, this is my recently added test. I'll look at it on the weekend.

I was under the impression the original p8_primary_test() failed like
this from time to time as well, although it seems to fail more
reliably now.

ddraw/tests: Use wine_dbgstr_rect() in the ddraw7 tests.

[Stefan Dösinger]

> Am 09.06.2016 um 16:24 schrieb Henri Verbeet :
> I was under the impression the original p8_primary_test() failed like
> this from time to time as well, although it seems to fail more
> reliably now.

Afaics it used to crash. The "last test seen before the exception" prior to removing the old test doesn't quite make sense though.