Re: [PATCH 3/4] dmusic: COM cleanup of IReferenceClock.

[Nikolay Sivov]

On 5/11/2012 09:19, Christian Costa wrote:
> diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h
> index 73a05d4..96334c9 100644
> --- a/dlls/dmusic/dmusic_private.h
> +++ b/dlls/dmusic/dmusic_private.h
> @@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(REFIID riid, LPVOID *ppobj, LPUNK
> - IReferenceClockImpl implementation structure
>
> */
>   struct IReferenceClockImpl {
> - /* IUnknown fields */
> - const IReferenceClockVtbl *lpVtbl;
> - LONG           ref;
> - /* IUnknown fields */
> - IReferenceClock IReferenceClock_iface;
> - const IReferenceClockVtbl *lpVtbl;

You forgot to remove that, right?
> - LONG ref;

[PATCH 3/4] dmusic: COM cleanup of IReferenceClock.

[Christian Costa]

2012/5/11 Nikolay Sivov
> On 5/11/2012 09:19, Christian Costa wrote:
> > diff --git a/dlls/dmusic/dmusic_private.h b/dlls/dmusic/dmusic_private.h
> > index 73a05d4..96334c9 100644
> > --- a/dlls/dmusic/dmusic_private.h
> > +++ b/dlls/dmusic/dmusic_private.h
> > @@ -167,13 +167,14 @@ extern HRESULT WINAPI DMUSIC_CreateDMSynthPort(**REFIID
> > riid, LPVOID *ppobj, LPUNK
> > - IReferenceClockImpl implementation structure
> >
> > */
> >  struct IReferenceClockImpl {
> > - /* IUnknown fields */
> > - const IReferenceClockVtbl *lpVtbl;
> > - LONG           ref;
> > - /* IUnknown fields */
> > - IReferenceClock IReferenceClock_iface;
> - const IReferenceClockVtbl *lpVtbl;
> >
>
> You forgot to remove that, right?
> > Yes. Right ! :)