Re: [8/9] setupapi: implement SetupPromptForDiskA by wrapping around W version

[Juan Lang]

Hi Ricardo,

+    DialogTitleW = MultiByteToUnicode(DialogTitle, CP_UTF8);
You should be using CP_ACP here, not CP_UTF8.  Same applies to
remaining character conversions.  In fact, you could use strdupAtoW
instead.
--Juan

[8/9] setupapi: implement SetupPromptForDiskA by wrapping around W version

[Ricardo Filipe]

2009/2/19 Juan Lang
> Hi Ricardo,
> - DialogTitleW = MultiByteToUnicode(DialogTitle, CP_UTF8);
>
> You should be using CP_ACP here, not CP_UTF8.  Same applies to
> remaining character conversions.  In fact, you could use strdupAtoW
> instead.
> --Juan
>
> that is something i should have asked... i assumed using UTF8 would be

"safer" for the resources, since they can be in utf8 required languages...

i'll take this and your other suggestions into account and resend the
patches tomorrow. i just tried to split the patches as much as possible
maintaining "buildability" between patches.

thank you.