Re: [PATCH 14/14] msi: Add tests for MsiGetProductProperty.

[Paul Vriens]

James Hawkins wrote:
> dlls/msi/tests/package.c |  232 ++++++++++++++++++++++++++++++++++++++++++++++
>  1 files changed, 232 insertions(+), 0 deletions(-)

Hi James,

These fail on Win9x as we are relying on some registry keys that are NT+ specific:

9574     lstrcpyA(keypath, "Software\Microsoft\Windows\CurrentVersion\");
9575     lstrcatA(keypath, "Installer\UserData\S-1-5-18\Products\");
9576     lstrcatA(keypath, prod_squashed);

Can we skip these tests, like we do with some others:

scm = OpenSCManager(NULL, NULL, GENERIC_ALL);
if (!scm && (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED))
{
     win_skip("Different registry keys on Win9x and WinMe\n");
     return;
}

[PATCH 14/14] msi: Add tests for MsiGetProductProperty.

[James Hawkins]

On Wed, Dec 10, 2008 at 8:49 AM, Paul Vriens  wrote:
> James Hawkins wrote:
> > dlls/msi/tests/package.c |  232
> > ++++++++++++++++++++++++++++++++++++++++++++++
> >  1 files changed, 232 insertions(+), 0 deletions(-)
>
> Hi James,
>
> These fail on Win9x as we are relying on some registry keys that are NT+
> specific:
>
> 9574     lstrcpyA(keypath,
> "Software\Microsoft\Windows\CurrentVersion\");
> 9575     lstrcatA(keypath, "Installer\UserData\S-1-5-18\Products\");
> 9576     lstrcatA(keypath, prod_squashed);
>
> Can we skip these tests, like we do with some others:
>
> scm = OpenSCManager(NULL, NULL, GENERIC_ALL);
> if (!scm && (GetLastError() == ERROR_CALL_NOT_IMPLEMENTED))
> {
>    win_skip("Different registry keys on Win9x and WinMe\n");
>    return;
> }

Doesn't matter to me.