On 15 December 2015 at 17:41, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
dlls/d3drm/tests/24bpp.bmp | Bin 0 -> 195894 bytes dlls/d3drm/tests/8bpp.bmp | Bin 0 -> 2142 bytes dlls/d3drm/tests/Makefile.in | 4 +- dlls/d3drm/tests/d3drm.c | 400 +++++++++++++++++++++++++++++++++++++++++++ dlls/d3drm/tests/d3drmrs.rc | 28 +++ dlls/d3drm/tests/palette.bmp | Bin 0 -> 30054 bytes dlls/d3drm/tests/resources.h | 26 +++ 7 files changed, 457 insertions(+), 1 deletion(-) create mode 100644 dlls/d3drm/tests/24bpp.bmp create mode 100644 dlls/d3drm/tests/8bpp.bmp create mode 100644 dlls/d3drm/tests/d3drmrs.rc create mode 100644 dlls/d3drm/tests/palette.bmp create mode 100644 dlls/d3drm/tests/resources.h
I suppose I'm missing something subtle, but these bitmaps look like it would take considerably less bytes to just generate them in the test.
On Wed, Dec 16, 2015 at 3:27 AM, Henri Verbeet hverbeet@gmail.com wrote:
On 15 December 2015 at 17:41, Aaryaman Vasishta jem456.vasishta@gmail.com wrote:
dlls/d3drm/tests/24bpp.bmp | Bin 0 -> 195894 bytes dlls/d3drm/tests/8bpp.bmp | Bin 0 -> 2142 bytes dlls/d3drm/tests/Makefile.in | 4 +- dlls/d3drm/tests/d3drm.c | 400
+++++++++++++++++++++++++++++++++++++++++++
dlls/d3drm/tests/d3drmrs.rc | 28 +++ dlls/d3drm/tests/palette.bmp | Bin 0 -> 30054 bytes dlls/d3drm/tests/resources.h | 26 +++ 7 files changed, 457 insertions(+), 1 deletion(-) create mode 100644 dlls/d3drm/tests/24bpp.bmp create mode 100644 dlls/d3drm/tests/8bpp.bmp create mode 100644 dlls/d3drm/tests/d3drmrs.rc create mode 100644 dlls/d3drm/tests/palette.bmp create mode 100644 dlls/d3drm/tests/resources.h
I suppose I'm missing something subtle, but these bitmaps look like it would take considerably less bytes to just generate them in the test.
Correct. Slackner had mentioned the same on IRC. I actually generated those bitmaps on python so it shouldn't be too hard to get it ported to win32. I'll resend the patch with Stefan's changes and write my own bitmap generation functions to avoid this problem.
Thanks for the feedback!
Cheers, Aaryaman
-
Aaryaman Vasishta -
Henri Verbeet