Re: [PATCH v2 5/7] msvcrt: Interpret 'I' as size_t size specifier for integer conversions

[Piotr Caban]

On 11/02/15 22:26, Martin Storsjo wrote:
> -
>    format = "%Ix %d";
> -
>    r = sprintf(buffer,format,0x123456,1);
> -
>    ok(!strcmp(buffer,"123456 1"),"Pointer formatted incorrectly\n");
> -
>    ok( r==8, "return count wrong\n");

Please change the test failure message (I would prefer something like 
ok(!strcmp(...), "buffer = %s\n", buffer)).

Thanks,
Piotr

[PATCH v2 5/7] msvcrt: Interpret 'I' as size_t size specifier for integer conversions

[Martin Storsjö]

On Tue, 3 Nov 2015, Piotr Caban wrote:
> On 11/02/15 22:26, Martin Storsjo wrote:
> > -
> >    format = "%Ix %d";
> > -
> >    r = sprintf(buffer,format,0x123456,1);
> > -
> >    ok(!strcmp(buffer,"123456 1"),"Pointer formatted incorrectly\n");
> > -
> >    ok( r==8, "return count wrong\n");
>
> Please change the test failure message (I would prefer something like 
> ok(!strcmp(...), "buffer = %s\n", buffer)).

Oh, right - too much copypaste here. Will change.

// Martin