This led to the definition of a static variable which then was not used, so wasting space and/or triggering a compiler warning.
Signed-off-by: Gerald Pfeifer gerald@pfeifer.com --- dlls/wldap32/add.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/dlls/wldap32/add.c b/dlls/wldap32/add.c index 0a24d95f32..d28ad961e1 100644 --- a/dlls/wldap32/add.c +++ b/dlls/wldap32/add.c @@ -34,8 +34,6 @@ #include "wldap32.h" #include "wine/debug.h"
-WINE_DEFAULT_DEBUG_CHANNEL(wldap32); - #ifdef HAVE_LDAP static LDAPMod *nullattrs[] = { NULL }; #endif
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=64226
Your paranoid android.
=== debian10 (build log) ===
../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? Task: The win32 build failed
=== debian10 (build log) ===
../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? ../../../wine/include/wine/debug.h:472:58: error: ‘__wine_dbch___default’ undeclared (first use in this function); did you mean ‘__wine_dbg_header’? Task: The wow64 build failed
It's unused for you because you build without dependency library. See how TRACE()'s are used in this file, debug channel definition should be ifdefed the same way.
On Fri, 31 Jan 2020, Nikolay Sivov wrote:
It's unused for you because you build without dependency library. See how TRACE()'s are used in this file, debug channel definition should be ifdefed the same way.
Thank you, Nikolay. That was very helpful and actionable feedback. Updated patch coming...
Gerald
-
Gerald Pfeifer -
Marvin -
Nikolay Sivov