Re: riched20/tests: Fix a SysAllocString leak

[Nikolay Sivov]

On 3/12/2014 19:36, Jactry Zeng wrote:
> I made this leak, sorry.. :(
> "What goes around comes around" was confirmed! :p
>   VariantInit(&testfile);
>   V_VT(&testfile) = VT_BSTR;
>   V_BSTR(&testfile) = SysAllocString(filename);

No need for VariantInit() here.
> - SysFreeString(V_BSTR(&testfile));

It's cleaner to use VariantClear().

riched20/tests: Fix a SysAllocString leak

[Jactry Zeng]

2014-03-12 23:47 GMT+08:00 Nikolay Sivov :
> On 3/12/2014 19:36, Jactry Zeng wrote:
> > I made this leak, sorry.. :(
> > "What goes around comes around" was confirmed! :p
> >   VariantInit(&testfile);
> >   V_VT(&testfile) = VT_BSTR;
> >   V_BSTR(&testfile) = SysAllocString(filename);
>
> No need for VariantInit() here.
> > - SysFreeString(V_BSTR(&testfile));
>
> It's cleaner to use VariantClear().

Thank you, Nikolay!
I have sent a new one.
Proverb was confirmed again.. :(

--
Regards,
Jactry Zeng