Signed-off-by: Ziqing Hui zhui@codeweavers.com --- dlls/comctl32/tests/imagelist.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c index aa563574ed..d4da38b151 100644 --- a/dlls/comctl32/tests/imagelist.c +++ b/dlls/comctl32/tests/imagelist.c @@ -2460,7 +2460,6 @@ static void init_functions(void) X(ImageList_AddMasked); X(ImageList_DrawIndirect); X(ImageList_SetImageCount); - X(ImageList_SetImageCount); X2(ImageList_SetColorTable, 390); X(ImageList_GetFlags); X(ImageList_BeginDrag);
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=66281
Your paranoid android.
=== build (build log) ===
error: patch failed: dlls/comctl32/tests/imagelist.c:2460 Task: Patch failed to apply
=== debian10 (build log) ===
error: patch failed: dlls/comctl32/tests/imagelist.c:2460 Task: Patch failed to apply
=== debian10 (build log) ===
error: patch failed: dlls/comctl32/tests/imagelist.c:2460 Task: Patch failed to apply
That's weird that a white space disappeared in the patch. The patch looks good to me in my code editor and mail client. I'm using Thunderbird on Linux Mint 19 Cinnamon. Maybe it's a bug in my mail client? The email of the patch was generated by this command:
git format-patch --stdout origin | formail -ds &> "$HOME/.thunderbird/28j9qdm0.default/Mail/Local Folders/Drafts"
On 3/4/20 10:42 AM, Ziqing Hui wrote:
Signed-off-by: Ziqing Hui zhui@codeweavers.com
dlls/comctl32/tests/imagelist.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c index aa563574ed..d4da38b151 100644 --- a/dlls/comctl32/tests/imagelist.c +++ b/dlls/comctl32/tests/imagelist.c @@ -2460,7 +2460,6 @@ static void init_functions(void) X(ImageList_AddMasked); X(ImageList_DrawIndirect); X(ImageList_SetImageCount); - X(ImageList_SetImageCount); X2(ImageList_SetColorTable, 390); X(ImageList_GetFlags); X(ImageList_BeginDrag);
Emmm.. I think it's likely that I have some problem with the way my mail client handle white space.
On 3/4/20 11:14 AM, Ziqing Hui wrote:
That's weird that a white space disappeared in the patch. The patch looks good to me in my code editor and mail client. I'm using Thunderbird on Linux Mint 19 Cinnamon. Maybe it's a bug in my mail client? The email of the patch was generated by this command:
git format-patch --stdout origin | formail -ds &> "$HOME/.thunderbird/28j9qdm0.default/Mail/Local Folders/Drafts"
On 3/4/20 10:42 AM, Ziqing Hui wrote:
Signed-off-by: Ziqing Hui zhui@codeweavers.com
dlls/comctl32/tests/imagelist.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/dlls/comctl32/tests/imagelist.c b/dlls/comctl32/tests/imagelist.c index aa563574ed..d4da38b151 100644 --- a/dlls/comctl32/tests/imagelist.c +++ b/dlls/comctl32/tests/imagelist.c @@ -2460,7 +2460,6 @@ static void init_functions(void) X(ImageList_AddMasked); X(ImageList_DrawIndirect); X(ImageList_SetImageCount); - X(ImageList_SetImageCount); X2(ImageList_SetColorTable, 390); X(ImageList_GetFlags); X(ImageList_BeginDrag);
-
Marvin -
Ziqing Hui