Re: wordpad: #1 Store bar states in the registry

[Alexandre Julliard]

Alexander Nicolaysen Sørnes  writes:
> wordpad: #1 Store bar states in the registry

This doesn't work well when resizing the window, the toolbars get
overwritten by the edit area.

wordpad: #1 Store bar states in the registry

[Alexander Nicolaysen Sørnes]

Tirsdag 11 september 2007 12:10, skrev du :
> Alexander Nicolaysen Sørnes  writes:
> > wordpad: #1 Store bar states in the registry
>
> This doesn't work well when resizing the window, the toolbars get
> overwritten by the edit area.

I'll try to fix this.  It's not a problem with this patch, though; it's 
already present in Wine GIT.

Alexander N. Sørnes

wordpad: #1 Store bar states in the registry

[Alexandre Julliard]

Alexander Nicolaysen Sørnes  writes:
> Tirsdag 11 september 2007 12:10, skrev du :
> > Alexander Nicolaysen Sørnes  writes:
> > > wordpad: #1 Store bar states in the registry
> >
> > This doesn't work well when resizing the window, the toolbars get
> > overwritten by the edit area.
>
> I'll try to fix this.  It's not a problem with this patch, though; it's 
> already present in Wine GIT.

Are you sure?  It works fine for me in current git.

wordpad: #1 Store bar states in the registry

[Alexander Nicolaysen Sørnes]

On Tuesday 11 September 2007 18:05:51 you wrote:
> Alexander Nicolaysen Sørnes  writes:
> > Tirsdag 11 september 2007 12:10, skrev du :
> > > Alexander Nicolaysen Sørnes  writes:
> > > > wordpad: #1 Store bar states in the registry
> > >
> > > This doesn't work well when resizing the window, the toolbars get
> > > overwritten by the edit area.
> >
> > I'll try to fix this.  It's not a problem with this patch, though; it's
> > already present in Wine GIT.
>
> Are you sure?  It works fine for me in current git.

Positive; and I tested with Wine 0.9.44 and GIT without my unapplied patches.  
It needs the WS_CLIPCHILDREN style for the main window, which is not set.  I 
sent the WS_CLIPCIHLDREN patch to Eric for review, but I don't think there is 
anything wrong with it.

Alexander N. Sørnes

wordpad: #1 Store bar states in the registry

[Alexandre Julliard]

Alexander Nicolaysen Sørnes  writes:
> Positive; and I tested with Wine 0.9.44 and GIT without my unapplied patches.  
> It needs the WS_CLIPCHILDREN style for the main window, which is not set.  I 
> sent the WS_CLIPCIHLDREN patch to Eric for review, but I don't think there is 
> anything wrong with it.

The flickering exists today, that's true, but with your patch it gets
much worse, the toolbars not only flicker but the edit is actually
resized over the whole window, and the toolbars disappear completely.

wordpad: #1 Store bar states in the registry

[Alexander Nicolaysen Sørnes]

On Tuesday 11 September 2007 20:57:17 you wrote:
> Alexander Nicolaysen Sørnes  writes:
> > Positive; and I tested with Wine 0.9.44 and GIT without my unapplied
> > patches. It needs the WS_CLIPCHILDREN style for the main window, which is
> > not set.  I sent the WS_CLIPCIHLDREN patch to Eric for review, but I
> > don't think there is anything wrong with it.
>
> The flickering exists today, that's true, but with your patch it gets
> much worse, the toolbars not only flicker but the edit is actually
> resized over the whole window, and the toolbars disappear completely.

Ok, I see what you mean.  I didn't seem all that different from the previous 
behaviour, though.  The CLIPCHILDREN patch can be applied before the others.

Alexander N. Sørnes

wordpad: #1 Store bar states in the registry

[Alexandre Julliard]

Alexander Nicolaysen Sørnes  writes:
> Ok, I see what you mean.  I didn't seem all that different from the previous 
> behaviour, though.  The CLIPCHILDREN patch can be applied before the others.

It's very different, the previous behavior is purely cosmetic, but
with your patch the app becomes unusable as soon as you resize the
window, since the text and toolbar now overlap.

wordpad: #1 Store bar states in the registry (try 2)

[Alexander Nicolaysen Sørnes]

On Tuesday 11 September 2007 21:30:41 you wrote:
> Alexander Nicolaysen Sørnes  writes:
> > Ok, I see what you mean.  I didn't seem all that different from the
> > previous behaviour, though.  The CLIPCHILDREN patch can be applied before
> > the others.
>
> It's very different, the previous behavior is purely cosmetic, but
> with your patch the app becomes unusable as soon as you resize the
> window, since the text and toolbar now overlap.

Ah, I think I see what you mean.  Sorry for all the mess.

When all toolbars were hidden the edit control would still be placed as though 
one of the bars were visible.  It would not cause any loss of functionality, 
though, but it would look like it.  That is because of a bug in our rebar 
code (bug 9450)

This version updates the hack for builtin richedit.

Alexander N. Sørnes