wine-mono 4.8.0 build

[Michael Cronenworth]

Hi,

The 4.8.0 wine-mono release cannot be built from source on Fedora. There seems to be 
something missing from the build root or not compiling during the build and I cannot 
see what it is. Can I borrow another set of eyes to look at the build output?

Build log: https://kojipkgs.fedoraproject.org//work/tasks/7904/33137904/build.log
Koji task: https://koji.fedoraproject.org/koji/taskinfo?taskID=33137904

Thanks,
Michael

[Vincent Povirk]

> BUILDSTDERR: Unhandled Exception:
> BUILDSTDERR: System.TypeInitializationException: The type initializer for 'System.Random' threw an exception. ---> System.DllNotFoundException: System.Native assembly:<unknown assembly> type:<unknown type> member:(null)

This looks similar to an issue I had when I was trying to use the
Linux class libraries inside Wine. One of the changes brought in by
our merge from upstream Mono is that the class libraries are now
platform-specific.

I'm not sure why the error is happening in the build process.

And yes, the network shouldn't be used here. It only attempts that
because the included monolite failed. The tarballs should be
sufficient for a successful build.

[Vincent Povirk]

Looks like this is my fault. The monolite included in the tarball is
wrong or broken, and I didn't notice because of the network fallback.

I'll see if I can fix this and get a revision out, and in the longer
term try to prevent official builds from using the network (this may
be tricky because vagrant uses the network for communication between
the host and the build vm).

[Michael Cronenworth]

On 3/4/19 9:40 AM, Vincent Povirk wrote:
> Looks like this is my fault. The monolite included in the tarball is
> wrong or broken, and I didn't notice because of the network fallback.
>
> I'll see if I can fix this and get a revision out, and in the longer
> term try to prevent official builds from using the network (this may
> be tricky because vagrant uses the network for communication between
> the host and the build vm).

Excellent. Thanks, Vincent. I was going to ask if the monolite was correct or not.

For your official builds you could borrow mock's feature by using a chroot with no 
network routes. Mock is what Fedora uses to build RPMs.

Thanks,
Michael

[Vincent Povirk]

Looks like this may not be the monolite build after all. Can you test
whether the attached patch fixes it?

[Michael Cronenworth]

On 3/4/19 1:56 PM, Vincent Povirk wrote:
> Looks like this may not be the monolite build after all. Can you test
> whether the attached patch fixes it?

Yes, this patch fixes it. Thanks.