Hi,
While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at https://testbot.winehq.org/JobDetails.pl?Key=19589
Your paranoid android.
=== wvistau64 (32 bit shlexec) === shlexec.c:141: Test failed: ShellExecute(verb="QuotedUpperL", file="C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1567: Test failed: argvA3 expected 'QuotedUpperL', but key not found or empty shlexec.c:1575: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec', but key not found or empty
=== w1064 (32 bit shlexec) === shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt1306.tmp\test file.sde") failed: rc=29 err=2
=== w1064 (64 bit shlexec) === shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2301: Test failed: ddeExec expected '[ifexec("C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde")]', got '[open("C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde")]' shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2 shlexec.c:2289: Test failed: ShellExecuteEx(mask="0x500", file="C:\Users\winetest\AppData\Local\Temp\wt72F2.tmp\test file.sde") failed: rc=29 err=2
On Sun, 10 Jan 2016, Marvin wrote: [...]
=== wvistau64 (32 bit shlexec) === shlexec.c:141: Test failed: ShellExecute(verb="QuotedUpperL", file="C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec") WaitForSingleObject returned 258 shlexec.c:1567: Test failed: argvA3 expected 'QuotedUpperL', but key not found or empty shlexec.c:1575: Test failed: argvA4 expected 'C:\Users\winetest\AppData\Local\Temp\wtD538.tmp\test file.shlexec', but key not found or empty
It looks like these were a one-time error. I have rerun the test and it succeeded. Furthermore all the patch did is add one ok() call and that call did not fail.
https://testbot.winehq.org/JobDetails.pl?Key=19612
=== w1064 (32 bit shlexec) === === w1064 (64 bit shlexec) ===
And these are the usual Windows 10 DDE failures.