Re: winemenubuilder: Look for supported color depths icons only. [resend]

[Frank Richter]

On 30.11.2006 01:54, Vitaliy Margolen wrote:
> Remove all the code simplification. This patch fixes icon extraction for
> most steam games. All HL2 based games have .ico file with 32-bit colors.
> Since we don't support those,

Or write the icons as PNGs.

-f.r.

winemenubuilder: Look for supported color depths icons only. [resend]

[Frank Richter]

On 30.11.2006 02:46, Frank Richter wrote:
> On 30.11.2006 01:54, Vitaliy Margolen wrote:
> > Remove all the code simplification. This patch fixes icon extraction for
> > most steam games. All HL2 based games have .ico file with 32-bit colors.
> > Since we don't support those,
>
> Or write the icons as PNGs.

The portland utils come with an utility to install icon resources:
http://portland.freedesktop.org/xdg-utils-1.0/xdg-icon-resource.html

That tool would also allow to take advantage of the fact that Windows
icons usually have multiple resolutions (ie extract more than one size).
The current XPM icon writer could still be used when backwards
compatibility is needed.

-f.r.

winemenubuilder: Look for supported color depths icons only. [resend]

[Vitaliy Margolen]

Frank Richter wrote:
> On 30.11.2006 01:54, Vitaliy Margolen wrote:
> > Remove all the code simplification. This patch fixes icon extraction for
> > most steam games. All HL2 based games have .ico file with 32-bit colors.
> > Since we don't support those,
>
> Or write the icons as PNGs.

Right, tried that before. Those patch(es) were not applied.

Vitaliy.

winemenubuilder: Look for supported color depths icons only. [resend]

[Frank Richter]

On 30.11.2006 03:29, Vitaliy Margolen wrote:
> Frank Richter wrote:
> > On 30.11.2006 01:54, Vitaliy Margolen wrote:
> > > Remove all the code simplification. This patch fixes icon extraction for
> > > most steam games. All HL2 based games have .ico file with 32-bit colors.
> > > Since we don't support those,
> >
> > Or write the icons as PNGs.
>
> Right, tried that before. Those patch(es) were not applied.

Any idea why? I tried to search gmane but did only find the original
patches but no replies.

-f.r.

winemenubuilder: Look for supported color depths icons only. [resend]

[Vitaliy Margolen]

Frank Richter wrote:
> On 30.11.2006 03:29, Vitaliy Margolen wrote:
> > Frank Richter wrote:
> > > On 30.11.2006 01:54, Vitaliy Margolen wrote:
> > > > Remove all the code simplification. This patch fixes icon extraction for
> > > > most steam games. All HL2 based games have .ico file with 32-bit colors.
> > > > Since we don't support those,
> > >
> > > Or write the icons as PNGs.
> >
> > Right, tried that before. Those patch(es) were not applied.
>
> Any idea why? I tried to search gmane but did only find the original
> patches but no replies.

I think there are few too hackish things in there:
http://winehq.org/pipermail/wine-patches/2006-January/023675.html

Vitaliy.