Re: shlwapi: implement StrChrNW

[Dmitry Timoshkov]

"Aric Stewart"  wrote:
> +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax)
> +{
> - TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch);
> -
> - if (lpszStr)
> - {
> - ch = toupperW(ch);
> - while (*lpszStr && cchMax > 0)
> - {
> -
>  if (toupperW(*lpszStr) == ch)
> -
>    return (LPWSTR)lpszStr;
> -
>  lpszStr++;
> -
>  cchMax --;
> - }
> - lpszStr = NULL;
> - }
> - return (LPWSTR)lpszStr;
>
> +}

Are you sure that the search should be case insensitive?

shlwapi: implement StrChrNW

[Bruno Jesus]

On Thu, Sep 24, 2009 at 00:32, Dmitry Timoshkov  wrote:
> "Aric Stewart"  wrote:
> > +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax)
> > +{
> > - TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch);
> > -
> > - if (lpszStr)
> > - {
> > - ch = toupperW(ch);
> > - while (*lpszStr && cchMax > 0)
> > - {
> > - if (toupperW(*lpszStr) == ch)
> > - return (LPWSTR)lpszStr;
> > - lpszStr++;
> > - cchMax --;
> > - }
> > - lpszStr = NULL;
> > - }
> > - return (LPWSTR)lpszStr;
> >
> > +}
>
> Are you sure that the search should be case insensitive?

It's stated in the microsoft page :
http://msdn.microsoft.com/en-us/library/cc836542%28VS.85%29.aspx

Bruno
> --
> Dmitry.