-------------------------------------------------- From: "Jacek Caban" jacek@codeweavers.com Sent: Saturday, August 16, 2008 8:18 PM To: wine-devel@winehq.org Cc: "Alistair Leslie-Hughes" leslie_alistair@hotmail.com Subject: Re: [1/2] mshtml: Changed get_typeinfo to help support IDispatch
Alistair Leslie-Hughes wrote:
Hi,
Changelog: mshtml: Changed get_typeinfo to help support IDispatch Subject: [PATCH] Changed get_typeinfo to AddRef the COM pointer
get_typeinfo is an internal function so it's fine to not AddRef as long as we guarantee that we hold the reference (and we do) so there is no point to add unneeded AddRef here.
I based the msxml get_typeinfo on the mshtml implementation, and it was initial rejected due to the missing AddRef's. So before I started Implementing more of the IDispatch functions, I thought this was the right thing todo.
Best Regards Alistair Leslie-Hughes