Hi,
With a lot of wines configuration moving over to HKEY_LOCAL_USER and magic comments being added to identify places where configuration is read, I though it may be a good idea to move over to a standard function for reading configuration instead of using direct registry access.
Something like GetWineConfiguration(USER|MACHINE, "PATH FROM .../wine/", "DEFAULT");
This would enable us to remove the magic comments, make it easier to migrate wines configuration at some point in the future if it's required again and easily lookup per application configuration as well as default behaviour without having to code it explicitly every time.
___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com
Oliver Stieber wrote:
With a lot of wines configuration moving over to HKEY_LOCAL_USER and magic comments being added to identify places where configuration is read, I though it may be a good idea to move over to a standard function for reading configuration instead of using direct registry access.
Something like GetWineConfiguration(USER|MACHINE, "PATH FROM .../wine/", "DEFAULT");
We want to stick to the Windows API in our code in order to make compiling our code on Windows or Reactos easier. Every new non-standard function we add makes porting more difficult, so we try to avoid adding anything that's not in the Win32 API.
Mike
--- Mike McCormack mike@codeweavers.com wrote:
Oliver Stieber wrote:
With a lot of wines configuration moving over to HKEY_LOCAL_USER and magic comments being added to identify places where configuration is read, I
though
it may be a good idea to move over to a standard function for reading configuration instead of
using
direct registry access.
Something like Reconfiguration(USER|MACHINE, "PATH FROM .../wine/", "DEFAULT");
We want to stick to the Windows API in our code in order to make compiling our code on Windows or Reactos easier. Every new non-standard function we add makes porting more difficult, so we try to avoid adding anything that's not in the Win32 API.
Couldn't a macro or inline function be used, that way there wouldn't be any additional linker dependencies.
Mike
___________________________________________________________ Yahoo! Messenger - NEW crystal clear PC to PC calling worldwide with voicemail http://uk.messenger.yahoo.com
Oliver Stieber wrote:
Couldn't a macro or inline function be used, that way there wouldn't be any additional linker dependencies.
Macros and inline functions are better than a function defined in a library, but each one introduces a header dependency, so they should also be avoided where possible.
Mike
-
Mike McCormack -
Oliver Stieber