Re: kernel32 translation

[Gustavo]

Em 7 de julho de 2010 05:36, Michael Stefaniuc  escreveu:
> Hello Gustavo,
>
> Gustavo wrote:
> > I'm approaching 100% of translation of wine to Brazilian Portuguese :D
>
> Cool, great job!
> > As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in
> > Brazilian Portuguese is actually translated in European Portuguese. As I
> > can see, only the "default sublanguages" languages have that file
> > translated, so it is supposed to stay that way, isn't it?
>
> Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not
> DEFAULT. DEFAULT sublang for Portuguese is SUBLANG_PORTUGUESE_BRAZILIAN.
> You can see it on
> http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2...
> "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)"
>
> If the pt_BR translation of those messages is different you can copy
> winerr_ptg.mc to winerr_ptb.mc and adapt it for
> SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is:
>  LanguageNames=(PTB=0x0116:winerr)

Ok, I understand, but wouldn't it be 0x0416? That's what it says in
locale_rc.rc:

#include "nls/ptb.nls"   /* 0x0416  LANG_PORTUGUESE,
SUBLANG_PORTUGUESE_BRAZILIAN */

kernel32 translation

[Michael Stefaniuc]

Gustavo wrote:
> Em 7 de julho de 2010 05:36, Michael Stefaniuc  escreveu:
> > Hello Gustavo,
> >
> > Gustavo wrote:
> > > I'm approaching 100% of translation of wine to Brazilian Portuguese :D
> >
> > Cool, great job!
> > > As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in
> > > Brazilian Portuguese is actually translated in European Portuguese. As I
> > > can see, only the "default sublanguages" languages have that file
> > > translated, so it is supposed to stay that way, isn't it?
> >
> > Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not
> > DEFAULT. DEFAULT sublang for Portuguese is SUBLANG_PORTUGUESE_BRAZILIAN.
> > You can see it on
> > http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2...
> > "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)"
> >
> > If the pt_BR translation of those messages is different you can copy
> > winerr_ptg.mc to winerr_ptb.mc and adapt it for
> > SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is:
> >  LanguageNames=(PTB=0x0116:winerr)
>
> Ok, I understand, but wouldn't it be 0x0416? That's what it says in
> locale_rc.rc:
>
> #include "nls/ptb.nls"   /* 0x0416  LANG_PORTUGUESE,
> SUBLANG_PORTUGUESE_BRAZILIAN */

Hmm... looks that you are right:
http://msdn.microsoft.com/en-us/library/aa912040.aspx
but
include/winnt.h:#define SUBLANG_PORTUGUESE_BRAZILIAN       0x01
I wonder if the bits 8+9 are used for something else and the SUBLANG
starts at bit 10. Yepp, that is that way:
include/winnt.h:#define MAKELANGID(p, s) ((((WORD)(s))<<10) | (WORD)(p))

bye
    michael

kernel32 translation

[Paul Vriens]

On 07/07/2010 01:13 PM, Michael Stefaniuc wrote:
> Gustavo wrote:
> > Em 7 de julho de 2010 05:36, Michael Stefaniuc  escreveu:
> > > Hello Gustavo,
> > >
> > > Gustavo wrote:
> > > > I'm approaching 100% of translation of wine to Brazilian Portuguese :D
> > >
> > > Cool, great job!
> > > > As can be seen in wine statistics, the MESSAGE #1 from dlls/kernel32 in
> > > > Brazilian Portuguese is actually translated in European Portuguese. As I
> > > > can see, only the "default sublanguages" languages have that file
> > > > translated, so it is supposed to stay that way, isn't it?
> > >
> > > Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not
> > > DEFAULT. DEFAULT sublang for Portuguese is SUBLANG_PORTUGUESE_BRAZILIAN.
> > > You can see it on
> > > http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2...
> > > "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)"
> > >
> > > If the pt_BR translation of those messages is different you can copy
> > > winerr_ptg.mc to winerr_ptb.mc and adapt it for
> > > SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is:
> > >   LanguageNames=(PTB=0x0116:winerr)
> >
> > Ok, I understand, but wouldn't it be 0x0416? That's what it says in
> > locale_rc.rc:
> >
> > #include "nls/ptb.nls"   /* 0x0416  LANG_PORTUGUESE,
> > SUBLANG_PORTUGUESE_BRAZILIAN */
>
> Hmm... looks that you are right:
> http://msdn.microsoft.com/en-us/library/aa912040.aspx
> but
> include/winnt.h:#define SUBLANG_PORTUGUESE_BRAZILIAN       0x01
> I wonder if the bits 8+9 are used for something else and the SUBLANG
> starts at bit 10. Yepp, that is that way:
> include/winnt.h:#define MAKELANGID(p, s) ((((WORD)(s))<<10) | (WORD)(p))
>
> bye
>    michael

If Portuguese(Brazil) needs a separate winerr file that would also means 
we need to change winerr_ptg.mc to show 0x816, not?

kernel32 translation

[Michael Stefaniuc]

Paul Vriens wrote:
> On 07/07/2010 01:13 PM, Michael Stefaniuc wrote:
> > Gustavo wrote:
> > > Em 7 de julho de 2010 05:36, Michael Stefaniuc 
> > > escreveu:
> > > > Hello Gustavo,
> > > >
> > > > Gustavo wrote:
> > > > > I'm approaching 100% of translation of wine to Brazilian Portuguese :D
> > > >
> > > > Cool, great job!
> > > > > As can be seen in wine statistics, the MESSAGE #1 from
> > > > > dlls/kernel32 in
> > > > > Brazilian Portuguese is actually translated in European Portuguese.
> > > > > As I
> > > > > can see, only the "default sublanguages" languages have that file
> > > > > translated, so it is supposed to stay that way, isn't it?
> > > >
> > > > Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not
> > > > DEFAULT. DEFAULT sublang for Portuguese is
> > > > SUBLANG_PORTUGUESE_BRAZILIAN.
> > > > You can see it on
> > > > http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2...
> > > >
> > > > "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)"
> > > >
> > > > If the pt_BR translation of those messages is different you can copy
> > > > winerr_ptg.mc to winerr_ptb.mc and adapt it for
> > > > SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is:
> > > >   LanguageNames=(PTB=0x0116:winerr)
> > >
> > > Ok, I understand, but wouldn't it be 0x0416? That's what it says in
> > > locale_rc.rc:
> > >
> > > #include "nls/ptb.nls"   /* 0x0416  LANG_PORTUGUESE,
> > > SUBLANG_PORTUGUESE_BRAZILIAN */
> >
> > Hmm... looks that you are right:
> > http://msdn.microsoft.com/en-us/library/aa912040.aspx
> > but
> > include/winnt.h:#define SUBLANG_PORTUGUESE_BRAZILIAN       0x01
> > I wonder if the bits 8+9 are used for something else and the SUBLANG
> > starts at bit 10. Yepp, that is that way:
> > include/winnt.h:#define MAKELANGID(p, s) ((((WORD)(s))<<10) | (WORD)(p))
> >
> > bye
> >     michael
>
> If Portuguese(Brazil) needs a separate winerr file that would also means
> we need to change winerr_ptg.mc to show 0x816, not?

Well we can change it but there is no need. Hmmm...
I wonder if we can put part of the messages in a SUBLANG_NEUTRAL
Portuguese file and have only the messages that differ in separate files.

bye
    michael

kernel32 translation

[Gustavo]

2010/7/7 Michael Stefaniuc :
> Paul Vriens wrote:
> > On 07/07/2010 01:13 PM, Michael Stefaniuc wrote:
> > > Gustavo wrote:
> > > > Em 7 de julho de 2010 05:36, Michael Stefaniuc
> > > > escreveu:
> > > > > Hello Gustavo,
> > > > >
> > > > > Gustavo wrote:
> > > > > > I'm approaching 100% of translation of wine to Brazilian Portuguese :D
> > > > >
> > > > > Cool, great job!
> > > > > > As can be seen in wine statistics, the MESSAGE #1 from
> > > > > > dlls/kernel32 in
> > > > > > Brazilian Portuguese is actually translated in European Portuguese.
> > > > > > As I
> > > > > > can see, only the "default sublanguages" languages have that file
> > > > > > translated, so it is supposed to stay that way, isn't it?
> > > > >
> > > > > Not really. LANG_PORTUGUESE, SUBLANG_PORTUGUESE is the NEUTRAL form not
> > > > > DEFAULT. DEFAULT sublang for Portuguese is
> > > > > SUBLANG_PORTUGUESE_BRAZILIAN.
> > > > > You can see it on
> > > > > http://source.winehq.org/transl/resfile.php?lang=016%3A01&resfile=dlls%2...
> > > > >
> > > > > "resource MESSAGE #1: Translation inherited from Portuguese (Neutral)"
> > > > >
> > > > > If the pt_BR translation of those messages is different you can copy
> > > > > winerr_ptg.mc to winerr_ptb.mc and adapt it for
> > > > > SUBLANG_PORTUGUESE_BRAZILIAN. The magic number for pt_BR is:
> > > > >   LanguageNames=(PTB=0x0116:winerr)
> > > >
> > > > Ok, I understand, but wouldn't it be 0x0416? That's what it says in
> > > > locale_rc.rc:
> > > >
> > > > #include "nls/ptb.nls"   /* 0x0416  LANG_PORTUGUESE,
> > > > SUBLANG_PORTUGUESE_BRAZILIAN */
> > >
> > > Hmm... looks that you are right:
> > > http://msdn.microsoft.com/en-us/library/aa912040.aspx
> > > but
> > > include/winnt.h:#define SUBLANG_PORTUGUESE_BRAZILIAN       0x01
> > > I wonder if the bits 8+9 are used for something else and the SUBLANG
> > > starts at bit 10. Yepp, that is that way:
> > > include/winnt.h:#define MAKELANGID(p, s) ((((WORD)(s))<<10) | (WORD)(p))
> > >
> > > bye
> > >     michael
> >
> > If Portuguese(Brazil) needs a separate winerr file that would also means
> > we need to change winerr_ptg.mc to show 0x816, not?
>
> Well we can change it but there is no need. Hmmm...
> I wonder if we can put part of the messages in a SUBLANG_NEUTRAL
> Portuguese file and have only the messages that differ in separate files.

I've already had problems when the strings are in the same stringtable
but part of it is in SUBLANG_PORTUGUESE (or
SUBLANG_PORTUGUESE_BRAZILIAN) and the other part is in
SUBLANG_NEUTRAL, therefore I think this is not possible.

I will change winerr_ptg.mc file accordingly in a separate patch after
I translate the file so it can be either committed or rejected at the
committer's will.

Gustavo.

kernel32 translation

[Paul Vriens]

On 07/07/2010 06:25 PM, Michael Stefaniuc wrote:
> > If Portuguese(Brazil) needs a separate winerr file that would also means
> > we need to change winerr_ptg.mc to show 0x816, not?
>
> Well we can change it but there is no need. Hmmm...
> I wonder if we can put part of the messages in a SUBLANG_NEUTRAL
> Portuguese file and have only the messages that differ in separate files.

It's already in a neutral file. Both sublanguages show that they 
inherited kernel32 (MESSAGE #1) from "Portuguese (Neutral)"

I'm curious what the benefit would be of having 3 files in the end 
instead of 2. It will also be a maintenance nightmare, not?

When we will have po files after 1.2 I guess that will also take care of 
the winerr stuff and we'll end up with an explicit sublanguage file 
anyway, I guess.