Re: [PATCH 04/10] ddraw/tests: New visual back buffer flipping tests. (try 3)

[Stefan Dösinger]

Am 03.08.2010 um 21:26 schrieb Oldřich Jedlička:
> - whiteBrush = CreateSolidBrush(white);
> - ok(whiteBrush != NULL, "CreateBrush returned: %p\n", whiteBrush);
> - redBrush = CreateSolidBrush(red);
> - ok(redBrush != NULL, "CreateBrush returned: %p\n", redBrush);
> -
> - hr = IDirectDrawSurface_GetDC(Backbuffer, &dc);
> - ok(hr == DD_OK, "IDirectDrawSurface_GetDC returned: %x\n", hr);
> - ret = FillRect(dc, &rect, redBrush);
> - ok(ret != 0, "FillRect failed\n");
> - hr = IDirectDrawSurface_ReleaseDC(Backbuffer, dc);
> - ok(hr == DD_OK, "IDirectDrawSurface_ReleaseDC returned: %x\n", hr);

It would be more directdraw-ish to use a colorfill blit instead of getDC + gdi drawing.

Tests 1-3 and 5 look OK though.