Francois Gouget wrote:
Maarten, could you fix the following winapi_check warnings:
dlls/avicap32/avicap32_main.c: HAVE_V4L2 is not declared as a conditional dlls/avicap32/avicap32_main.c: HAVE_V4L2 is not declared as a conditional
The problem is that dlls/avicap32/avicap32_main.c checks for HAVE_V4L2 but we lack the appropriate check in configure.ac and the macro declaration in include/config.h.
HAVE_V4L2 is not declared in wine itself, but by /usr/include/linux/videodev.h, which includes videodev2.h and defines HAVE_V4L2 if V4L2 is available, so in my opinion it doesn't need fixing..
On 5/5/05, Maarten Lankhorst m.b.lankhorst@gmail.com wrote:
HAVE_V4L2 is not declared in wine itself, but by /usr/include/linux/videodev.h, which includes videodev2.h and defines HAVE_V4L2 if V4L2 is available, so in my opinion it doesn't need fixing..
Maybe we can have our cake and eat it too. Would it work to create our own HAVE_V4L2 (or use our own wine-specific name) with the respective checks in configure.ac and the macro declaration in include/config.h? The check would be whatever is needed to determine if V4L2 is available, like checking for the right header. We could then use our own check instead of depending on the V4L2 lib telling us if it's available.
James Hawkins wrote:
On 5/5/05, Maarten Lankhorst m.b.lankhorst@gmail.com wrote:
HAVE_V4L2 is not declared in wine itself, but by /usr/include/linux/videodev.h, which includes videodev2.h and defines HAVE_V4L2 if V4L2 is available, so in my opinion it doesn't need fixing..
Maybe we can have our cake and eat it too. Would it work to create our own HAVE_V4L2 (or use our own wine-specific name) with the respective checks in configure.ac and the macro declaration in include/config.h? The check would be whatever is needed to determine if V4L2 is available, like checking for the right header. We could then use our own check instead of depending on the V4L2 lib telling us if it's available.
If you want to write a patch go ahead, requirements for videodev2.h are exactly the same, but on the kernel versions I tested this with it would include videodev2.. but a check can't hurt
On Thu, 5 May 2005, Maarten Lankhorst wrote: [...]
HAVE_V4L2 is not declared in wine itself, but by /usr/include/linux/videodev.h, which includes videodev2.h and defines HAVE_V4L2 if V4L2 is available, so in my opinion it doesn't need fixing..
Ok. I'll send a patch to prevent winapi_check from complaining about HAVE_V4L2 since it's not an autoconf macro despite its look.
-
Francois Gouget -
James Hawkins -
Maarten Lankhorst