Hello Huw,
Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7:
font.c:5799: Test failed: 4(1): expected height 15, got 12 font.c:5808: 4(1): default gui font is MS UI Gothic
As both systems are running with Japanese locale, I compared my Windows 7 settings with testbot's one. And, I found that testbot returns different GetSystemDefaultUILanguage() value. In other words, testbot returns 0x0409 (English US)[1], but my PC returns 0x0411 (Japanese). [1] https://testbot.winehq.org/JobDetails.pl?Key=14511&log_206=1#k206
I'm not sure if the configuration is on purpose, or not. However, the test needs to be updated on that point.
Akihiro Sagawa
On 21 Jun 2015, at 04:05, Akihiro Sagawa wrote:
Hello Huw,
Hi,
Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7:
font.c:5799: Test failed: 4(1): expected height 15, got 12 font.c:5808: 4(1): default gui font is MS UI Gothic
Just to be clear, did this test succeed before my change? I can't see how it could have done, yet your email implies it did.
Thanks, Huw.
On Sun, 21 Jun 2015 10:15:05 +0100, Huw Davies wrote:
Could you improve commit c81ff0f8cfc1a7b6fa7546d8ffb656e290ef5e7e? I know this fixes longstanding test failure on Windows 7 testbot running with Japanese locale. But, the change leads to test failures on my Japanese Windows 7:
font.c:5799: Test failed: 4(1): expected height 15, got 12 font.c:5808: 4(1): default gui font is MS UI Gothic
Just to be clear, did this test succeed before my change? I can't see how it could have done, yet your email implies it did.
Sorry, the test failure is unrelated to your change. The test was failed before your commit both on my PC and testbot, too. I had wrong assumption from the code. So, <the change leads to test failures> isn't true.
What I'm trying to say is that the change is suppressing test failures. For instance, we can't find out SYSTEM_FONT's wrong face name issue because all face names don't start with `?'. I guess using GetSystemUILanguage() is a better way to skip unrelated test data. What do you think about this point?
Regards, Akihiro Sagawa
On Sun, 21 Jun 2015, Akihiro Sagawa wrote: [...]
As both systems are running with Japanese locale, I compared my Windows 7 settings with testbot's one. And, I found that testbot returns different GetSystemDefaultUILanguage() value. In other words, testbot returns 0x0409 (English US)[1], but my PC returns 0x0411 (Japanese). [1] https://testbot.winehq.org/JobDetails.pl?Key=14511&log_206=1#k206
I'm not sure if the configuration is on purpose, or not. However, the test needs to be updated on that point.
The TestBot's VM is an English Windows 7 Ultimate install that was configured for Japanese. As far as I can tell all the settings have been set to Japanese. Maybe GetSystemDefaultUILanguage() returns English because that's the default language you get during installation.
On Sun, 21 Jun 2015 16:57:00 +0200 (CEST), Francois Gouget wrote:
The TestBot's VM is an English Windows 7 Ultimate install that was configured for Japanese. As far as I can tell all the settings have been set to Japanese. Maybe GetSystemDefaultUILanguage() returns English because that's the default language you get during installation.
Thanks explanation. Indeed, GetSystemDefaultUILanguage() returns install language[1]. So, what about Welcome screen's display language? Because, some settings, like `MS Shell Dlg', follows the machine default UI language[2]. I think the machine default UI language equals Welcome screen's display language.
[1] https://msdn.microsoft.com/en-us/library/windows/desktop/dd319088%28v=vs.85%... [2] https://msdn.microsoft.com/en-us/library/windows/desktop/dd374112%28v=vs.85%...
Akihiro Sagawa
-
Akihiro Sagawa -
Francois Gouget -
Huw Davies