Resource accelerators discrepancies

[Frédéric Delanoy]

Hi Alexandre,

After your addition of accelerators to po file for winefile (among
others) [fe021a44 winefile: Add message contexts for accelerators that
can be translated], there seems to be some discrepancies:

#: winefile.rc:202
msgctxt "accelerator Fullscreen"
msgid "^S"

vs

#: winefile.rc:70
msgid "F&ull Screen\tCtrl+Shift+S"

and

#: winefile.rc:201 winemine.rc:99
msgctxt "accelerator Exit"
msgid "X"

vs

#: winefile.rc:38 winemine.rc:46
msgid "E&xit\tAlt+X"

winefile.rc contains:
-	"X", ID_FILE_EXIT, VIRTKEY, ALT
-	"S", ID_VIEW_FULLSCREEN, VIRTKEY, SHIFT, CONTROL
+	"#msgctxt#accelerator Exit#X", ID_FILE_EXIT, ALT
+	"#msgctxt#accelerator Fullscreen#^S", ID_VIEW_FULLSCREEN, SHIFT

So,
- is there a way/shouldn't the "label\tshortcut" menu entries be
automated somehow? E.g. so the accelerator is automatically extracted
- is only the Control modifier shown in msgids? E.g. "X" while the
shortcut is Alt-X. That's a bit inconsistent IMHO

Frédéric

[Alexandre Julliard]

Frédéric Delanoy  writes:
> After your addition of accelerators to po file for winefile (among
> others) [fe021a44 winefile: Add message contexts for accelerators that
> can be translated], there seems to be some discrepancies:

No, but you need to look up the resource definition to see all the
flags. That shouldn't matter for translating them.
> So,
> - is there a way/shouldn't the "label\tshortcut" menu entries be
>
> automated somehow? E.g. so the accelerator is automatically extracted

Not really.
> - is only the Control modifier shown in msgids? E.g. "X" while the
>
> shortcut is Alt-X. That's a bit inconsistent IMHO

That can't be avoided, unless we want to invent our own syntax for
specifying accelerators. Given how few we have, I don't think it's worth
the trouble. We could just as well kill the Alt-X shortcuts, they are
not really necessary.