2009/5/5 André Hentschel nerv@dawncrow.de:
dlls/comctl32/tests/listview.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
This patch fails without your other patch. In the future, please combine them into one patch, or number them in a series.
Wine must compile and pass the tests before and after every patch.
Austin English schrieb:
2009/5/5 André Hentschel nerv@dawncrow.de:
dlls/comctl32/tests/listview.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
This patch fails without your other patch. In the future, please combine them into one patch, or number them in a series.
Wine must compile and pass the tests before and after every patch.
Howdy, I made one patch out of them and improved my tests. now i wonder again why its not getting in... I know these questions are ugly... A System would be cool, where Alexandre always could do a one-click select of tags why a patch dont get in... Things like that are a difficult subject, are there good solutions in other projects?
André Hentschel wrote:
I made one patch out of them and improved my tests. now i wonder again why its not getting in...
You should use SNDMSGW.
Vitaliy.
Vitaliy Margolen wrote:
André Hentschel wrote:
I made one patch out of them and improved my tests. now i wonder again why its not getting in...
You should use SNDMSGW.
Vitaliy.
No actually. Native uses ListView_SetItemState for that macro which is SNDMSGA in wine and SNDMSG in native.
Nikolay Sivov wrote:
No actually. Native uses ListView_SetItemState for that macro which is SNDMSGA in wine and SNDMSG in native.
He asked why his patch is not getting in - that's one of the reasons. You should always use SendMessageW where possible. Especially for things that don't care if it's A or W. This is to prevent extra A->W conversions.
Vitaliy.
-
André Hentschel -
Austin English -
Nikolay Sivov -
Vitaliy Margolen