Re: [PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.

[Paul Vriens]

Jacek Caban wrote:
> dlls/mshtml/dispex.c         |    2 ++
>  dlls/mshtml/htmllocation.c   |    2 +-
>  dlls/mshtml/mshtml_private.h |    2 ++
>  dlls/mshtml/omnavigator.c    |    2 +-
>  dlls/mshtml/tests/dom.c      |   36 ++++++++++++++++++++++++++++++------
>  5 files changed, 36 insertions(+), 8 deletions(-)

Hi Jacek,

Thanks for looking into the IE8 test failures.

This piece however doesn't look correct:

+static void _test_disp2(unsigned line, IUnknown *unk, const IID *diid, 
const IID *diid2)
+{
+    IID iid;
+
+    if(_test_get_dispid(line, unk, &iid))
+        ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || 
broken(IsEqualGUID(&iid, diid)),
+                "unexpected guid %s\n", dbgstr_guid(&iid));

You are comparing twice against diid.

[PATCH 2/2] mshtml: Fixed tests on IE8 and change Wine behavior to IE8.

[Jacek Caban]

Hi Paul,

Paul Vriens wrote:
> This piece however doesn't look correct:
>
> +static void _test_disp2(unsigned line, IUnknown *unk, const IID 
> *diid, const IID *diid2)
> +{
> - IID iid;
> -
> - if(_test_get_dispid(line, unk, &iid))
> -
>    ok_(__FILE__,line) (IsEqualGUID(&iid, diid) || 
>
> broken(IsEqualGUID(&iid, diid)),
> -
>            "unexpected guid %s\n", dbgstr_guid(&iid));
>
> You are comparing twice against diid.

Right, good catch, the second test should compare against diid2.

Thanks,
    Jacek