Re: kernel32: add GetVolumeInformationByHandleW stub (try 2)

[Austin English]

On Wed, Apr 6, 2016 at 5:34 PM, Austin English  wrote:
> --
> -Austin

Could I get some feedback on this patch please?

kernel32: add GetVolumeInformationByHandleW stub (try 2)

[Alex Henrie]

Two things, both nitpicks:

1. I wrap lines to 120 characters. Most other developers wrap to 80 or
100. A line with 181 characters seems excessive.

2. Your prototype in winbase.h uses DWORD * and WCHAR * whereas the
surrounding prototypes use LPDWORD and LPWSTR.

-Alex

kernel32: add GetVolumeInformationByHandleW stub (try 2)

[Austin English]

On Wed, Apr 27, 2016 at 12:25 AM, Alex Henrie  wrote:
> Two things, both nitpicks:
> -
>
> I wrap lines to 120 characters. Most other developers wrap to 80 or
> -
>
> A line with 181 characters seems excessive.
> -
>
> Your prototype in winbase.h uses DWORD * and WCHAR * whereas the
>
> surrounding prototypes use LPDWORD and LPWSTR.
>
> -Alex

Thanks Alex.