Silencing a noisy fixme - feedback requested

[Austin English]

Howdy,

I was taking a look at some of the noisy fixme's, and wanted some
feedback on the attached patch.
This particular fixme is _really_ noisy...out of this
(http://bugs.winehq.org/attachment.cgi?id=16447)
log, it has 9635 of the 13117 lines!

"fixme:ntdll:NtLockFile I/O completion on lock not implemented yet" 9635 times!

Not sure if this is the best way to go about this or not. Any advice
appreciated (or if anyone else wants to silence it :-P).

-Austin

[Dimi Paun]

On Fri, 2008-10-03 at 11:46 -0500, Austin English wrote:
> - BOOLEAN     warn = TRUE;

This has to be static, else it will always be TRUE.

[Nikolay Sivov]

Austin English wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> log, it has 9635 of the 13117 lines!
>
> "fixme:ntdll:NtLockFile I/O completion on lock not implemented yet" 9635 times!
>
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).
>
> -Austin

Did you want static variable?

[Juan Lang]

Hi Austin,
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).

You're close.  The only fix is:
+    BOOLEAN     warn = TRUE;
should be static.  (Otherwise it'll be TRUE every time the function is
called, so it'll always be printed.)
--Juan

[Austin English]

On Fri, Oct 3, 2008 at 11:46 AM, Austin English  wrote:
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> log, it has 9635 of the 13117 lines!
>
> "fixme:ntdll:NtLockFile I/O completion on lock not implemented yet" 9635 times!
>
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).
>
> -Austin

How's this look?

Thanks for the quick help everyone!

-Austin

[Dimi Paun]

On Fri, 2008-10-03 at 12:01 -0500, Austin English wrote:
> - if (apc_user)
> -
>   if (warn) {
> -
>       FIXME("I/O completion on lock not implemented yet\n");
> -
>       warn = FALSE;
> -
>   }

It's a style thing, but I for one would much prefer
brackets around the outer if to prevent easy to make
mistakes with dandling ifs.

[Henri Verbeet]

2008/10/3 Austin English :
> Howdy,
>
> I was taking a look at some of the noisy fixme's, and wanted some
> feedback on the attached patch.

That patch won't make the FIXME any less noisy, for one.
> This particular fixme is _really_ noisy...out of this
> (http://bugs.winehq.org/attachment.cgi?id=16447)
> log, it has 9635 of the 13117 lines!
>
> "fixme:ntdll:NtLockFile I/O completion on lock not implemented yet" 9635 times!
>
> Not sure if this is the best way to go about this or not. Any advice
> appreciated (or if anyone else wants to silence it :-P).

In general I'm not a big fan of blindly silencing FIXMEs, probably
because scary text in scary consoles doesn't bother me much, and can
be useful on occasion.