Re: [07/10] wintrust: Implement CryptCATEnumerateMember.

[Alexandre Julliard]

Hans Leidekker  writes:
> @@ -496,12 +496,208 @@ BOOL WINAPI CryptCATClose(HANDLE hCatalog)
>      return TRUE;
>  }
>
> +static BOOL guid_from_string(const WCHAR *str, GUID *guid)
> +{
> - unsigned int i = 0;
> - unsigned char *b = (unsigned char *)guid;
> - const WCHAR *p = str;

Please call one of the existing functions for this instead of
reinventing the wheel.

[07/10] wintrust: Implement CryptCATEnumerateMember.

[Hans Leidekker]

On Monday 22 December 2008 14:55:29 Alexandre Julliard wrote:
> > +static BOOL guid_from_string(const WCHAR *str, GUID *guid)
> > +{
> > - unsigned int i = 0;
> > - unsigned char *b = (unsigned char *)guid;
> > - const WCHAR *p = str;
>
> Please call one of the existing functions for this instead of
> reinventing the wheel.

I did that at some point but it seemed overkill to me to import
ole32 for just one function. I'll change it.

-Hans

[07/10] wintrust: Implement CryptCATEnumerateMember.

[Alexandre Julliard]

Hans Leidekker  writes:
> On Monday 22 December 2008 14:55:29 Alexandre Julliard wrote:
> > > +static BOOL guid_from_string(const WCHAR *str, GUID *guid)
> > > +{
> > > - unsigned int i = 0;
> > > - unsigned char *b = (unsigned char *)guid;
> > > - const WCHAR *p = str;
> >
> > Please call one of the existing functions for this instead of
> > reinventing the wheel.
>
> I did that at some point but it seemed overkill to me to import
> ole32 for just one function. I'll change it.

You can always use RtlGUIDFromString or something like that.