Missed Patches

[Alistair Leslie-Hughes]

Hi,
    Is there any reason the following patches haven't been applied?
[1/2] msxml: Implement createTextNode

[2/2] msxml: Tests for createTextNode

mshtml: Provide support for the IInternetProtocol Interface

Best Regards

Alistair Leslie-Hughes

[Jacek Caban]

Alistair Leslie-Hughes wrote:
> Hi,
>     Is there any reason the following patches haven't been applied?

[...]
> mshtml: Provide support for the IInternetProtocol Interface

The patch is obviously wrong. Did you run tests with Gecko installed? It
probably won't fail, but you will see some tests skipped.

Jacek

[Alistair Leslie-Hughes]

"Jacek Caban"  wrote in message 
news:[e-mail]...
> Alistair Leslie-Hughes wrote:
> > Hi,
> >     Is there any reason the following patches haven't been applied?
>
> [...]
> > mshtml: Provide support for the IInternetProtocol Interface
>
> The patch is obviously wrong. Did you run tests with Gecko installed? It
> probably won't fail, but you will see some tests skipped.

Yes I did have Gecko installed when I ran the tests.  Ok, I see the skipped 
tests.

So I need to Run tests again without Gecko installed? (Correct test if 
needed)

Any other pointers?

Best Regards
 Alistair Leslie-Hughes

[Jacek Caban]

Alistair Leslie-Hughes wrote:
> Any other pointers?

This interface shouldn't be available in BSCallback. You probably added
it because of the FIXME message. I've sent a patch that silences it. In
the future you should check if interface is available in Windows before
adding them to Wine.

Jacek

[Alistair Leslie-Hughes]

"Jacek Caban"  wrote in message 
news:[e-mail]...
> Alistair Leslie-Hughes wrote:
> > Any other pointers?
>
> This interface shouldn't be available in BSCallback. You probably added
> it because of the FIXME message. I've sent a patch that silences it. In
> the future you should check if interface is available in Windows before
> adding them to Wine.

Yes, I did add it beacuse of the FIXME,  but that is beacuse the application 
Im trying to get running uses it.  (maybe Indirectly)

Without the patch I just get a access Voliation.  I see that it is wrong. 
How/where should I Implement it to stop the access
Voliation. I can provide stacktrace if needed.

Best Regards
Alistair leslie-Hughes