-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-02 um 20:24 schrieb Martell Malone:
- FIXME("stub: adapter %p, driver_type %s, swrast %p, flags
%#x, feature_levels %p, levels %#x, sdk_version %d, "
You're still printing sdk_version as a signed value. Please use %u instead of %d.
Otherwise this looks good to me.
D3D11CreateDevice also has "sdk_version %d" I used that as a reference. Does this mean that the other stub is wrong also ??
On Tue, Feb 3, 2015 at 8:13 AM, Stefan Dösinger stefandoesinger@gmail.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-02 um 20:24 schrieb Martell Malone:
- FIXME("stub: adapter %p, driver_type %s, swrast %p, flags
%#x, feature_levels %p, levels %#x, sdk_version %d, "
You're still printing sdk_version as a signed value. Please use %u instead of %d.
Otherwise this looks good to me.
-----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU0IM3AAoJEN0/YqbEcdMw5v8P/3A5kt9fIPCVCTgXfM0A6uKS 8cCXPITuKmeub7obw7EiEhsQH/4pw80bKOhmFKZvpK0knrKeU7wZvojbP18n39j1 vVqpqvtzbkfsBwLZ/Z0AeC/evVACfMmw1Al3BMBTDhxFb+uv+rVI9spG06XRPx8P e3pWlzoGniaZG8YP6TguA0gfrcMcGWEOWT59nstWW0HXlMFdsE1OoMM5Wd+XrpB+ AuEHGNFiHacgNxVfpnk6wQw5TK2uXW79ZbjX2wnrDiXkYvUZBts34Xo5cTdXNMXp DugbwLQtoC3Yu4rHxymjZTNbJLDY0bAOgBo4YwMCVnfLj7zbwvNABqtEIKtVs5Mx XsovTKzLD5sPmWnCxMtC5Qmz/aQebOYWF9bB3vYju876h69J5aJt4OjGU0HfLd4g 26uQEWgT+UbU0Lavofn3w9jcO4qEBl3NbmTs4egsw8n5Ry5f+N58BX1OdaOSdkmy a3Io6NgV48I/FjbxdlqpMz10I+06VlWiMdlmQSKxWTN1t5AxTm8/dTHLMC4+D7nn FOeWvOr3Wy4ocBWoOpT94etIBxut8IMfSHzEKsoll7kib3daYVDPv97pAbKdV3fT tZhzhWif+sqneVpk9QnCqhd9v9Kd29axqTBy7JiZ9t8TYxFTrXu50ZgC5oX/zKBV 4jVGoA2kY+Gtv9KR6SH0 =R0+9 -----END PGP SIGNATURE-----
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-03 um 18:22 schrieb Martell Malone:
D3D11CreateDevice also has "sdk_version %d" I used that as a reference. Does this mean that the other stub is wrong also ??
Yes, it should be fixed as well.
Since it is just a debug message it's a minor detail. We did have bugs because of signed and unsigned problems, and there are Windows programs that have bugs because of that, so we generally are careful about this.
I'll take a closer look at your patches tomorrow.
Yes, it should be fixed as well.
I will leave that to a separate patch
I'll take a closer look at your patches tomorrow.
Great. Thanks for taking the time to look. Jacek who usually does the idl's looked at them for me before I submitted and game me the all clear so I am hopeful that they pass :)
Kind Regards Martell
On Tue, Feb 3, 2015 at 8:23 PM, Stefan Dösinger stefandoesinger@gmail.com wrote:
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Am 2015-02-03 um 18:22 schrieb Martell Malone:
D3D11CreateDevice also has "sdk_version %d" I used that as a reference. Does this mean that the other stub is wrong also ??
Yes, it should be fixed as well.
Since it is just a debug message it's a minor detail. We did have bugs because of signed and unsigned problems, and there are Windows programs that have bugs because of that, so we generally are careful about this.
I'll take a closer look at your patches tomorrow. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2
iQIcBAEBAgAGBQJU0S44AAoJEN0/YqbEcdMwqqYP/0SLr9cunsGM6/wGKNCFFbCW 1h4zVor2BgHtvef1GQPyPnBZpl4TLFf+sQIBDjX3uKqGm4hZLqc4PLYuYB9uW0GM uXoJ+zx6QPuiA/2ghWFB+PVIsPAvLHFUvl7pV9535U2o3/aQSowJliO7ECYytsSE nEztx+RJoa/iWO4AwwcPOfjMqWbtdsYbS08B3tHfdJz+KAYAF8ZbLc2+GFoOCI1A RpkcO2PQSnIex3G5t/+GFHknU1viD4Z7Kiv17SkypjqafL7YGyG4nXXtXB1hWuP/ h3aSQfmT/RfDnrLjxgimaFx9e9a94C0ntdX42eYCdfoAw/HvfYL6yhdCXykjGAZ8 Hpn/xr4Lm9Q8bOe8R3W2LaW4jSWerICt/zDpyW6CW2rnFldftMWUx+hiIXKGmCfc jy2CQgZwrjqnjx68TW7K5tHcHiRpWccE3AT1V1xjwsSCFBXkMuN0v1oS4CVycO+K o428uUhqm59jwREMDFKfhq6M9Si3nHj6dMwEFOs4Pf2KlYJzfov0oVu6Q0ZiOzUk v4nk5TeY6jaKb1iaPnBd91jBEsqV3jsa/ZkOJvVofbZd2Kvj4paGGObREUWxctC6 ei2569LNyLufmtYVRkV6k7YvDpM8tYkalMcwQlRqosyObpA+nlgWgvFowju9Iabk Y4nr+FeqpIRzE2/07FFm =mnjg -----END PGP SIGNATURE-----
-
Martell Malone -
Stefan Dösinger