array out of bounds checking results

[Marcus Meissner]

Hi,

Yesterdays TRUNK gcc features array overflow checking... I have
run it against WINE and found 3 index overflows.

arb_program_shader.c:950: Warnung: array subscript is above array bounds
    This is the place in C:
        } else if(GL_SUPPORT(GL_VERTEX_PROGRAM_ARB)) {

and in preprocessed:
        } else if(((*gl_info).supported[0x8620] != 0)) {

The supported array is way smaller than that.

Likely a typo.

winaspi32.c:239: Warnung: array subscript is above array bounds
winaspi32.c:239: Warnung: array subscript is above array bounds
    This is this part:
    if (rqbuf[15]&0x8) {
          TRACE("Pointer at %d, bit %d\n",rqbuf[16]*256+rqbuf[17],rqbuf[15]&0x7);
        }

rqbuf points to SenseArea which is only 16 byte.
    I am unclear what exactly is meant to be done here. We only ever copy
    16 Byte into this array anyway.

Ciao, Marcus

[H. Verbeet]

On 20/01/07, Marcus Meissner  wrote:
>         } else if(GL_SUPPORT(GL_VERTEX_PROGRAM_ARB)) {

That should read "GL_SUPPORT(ARB_VERTEX_PROGRAM)"

[Stefan Dösinger]

Am Samstag 20 Januar 2007 13:57 schrieb H. Verbeet:
> On 20/01/07, Marcus Meissner  wrote:
> >         } else if(GL_SUPPORT(GL_VERTEX_PROGRAM_ARB)) {
>
> That should read "GL_SUPPORT(ARB_VERTEX_PROGRAM)"

Ooops, my fault :-|