Re: [PATCH 3/4] d3drm/tests: Split tests between different versions, initially adding frame QueryInterface tests

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

There are a few more issues:

Am 2015-04-02 um 18:36 schrieb Aaryaman Vasishta:
> -
> - Copyright 2012 Andr� Hentschel
> -
> - Copyright 2011-2014 Henri Verbeet for CodeWeavers

The encoding is still messed up.

Is there any code you have taken from the other file? test_qi() is
from dlls/ddraw/tests/ddraw*.c, so you should keep Henri's line.
Taking along all the Copyright lines if you take something from an
existing file is a safe choice though. Also, you should still fix your
editor settings anyways.

You can add your own name there if you want.

(Fwiw, I don't know why we're maintaining these lines at all. The last
thing I heard was that they don't have any legal meaning anyway. Also,
git keep track of authorship pretty well.)
> +#define CHECK_REFCOUNT(obj,rc) \
> - { \
> - int rc_new = rc; \
> - int count = get_refcount((IUnknown *)obj); \
> - ok(count == rc_new, "Invalid refcount. Expected %d got %d\n", rc_new, count); \
> - }

Do you need this? You're using this in one place as far as I can see,
you can also just use the get_refcount() and ok() calls directly.
> +static int get_refcount(IUnknown *object)
> +{
> - IUnknown_AddRef(object);
> - return IUnknown_Release(object);
>
> +}

Refcounts are ULONG.
> - hr = IDirect3DRM_CreateFrame(d3drm, NULL, &frame);
> - ok(hr == D3DRM_OK, "Cannot get IDirect3DRMFrame3 interface (hr = %x)\n", hr);

The string is a bit misleading, I think something like "Failed to
create frame" is better. Not a big issue though.

The same applies to d3drm2.c and d3drm3.c
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVHaNRAAoJEN0/YqbEcdMwZsAP/RvHLPjullG+tQC+JOZvzGDg
nm2CZanwOzmC8ZEvWpXKxhCUjTIVUu0XB7yV33BgPywgRKBUUXkqEuGN+Z/wk7Lm
rqNuPx17nPHL7aKjw9DxU3QP75t7RbFxU6N3Wz3Veoi+ox4xwxwmrIxRMkFNtxhv
tPREjNp9yQVO79ZlLzI1VzeMVnTHKgVn/L+s68nADUkcBFrQaH6SBhB232utwbtp
DdkwYOWCK0xGweaLAkt33X2Qhp+qbdtQjIoK/UZvq190owrW2tC2ORnIFhB/7zDR
+FrpGzwGuTnhVocrLYCtVtB1RW5t0QealNjhlwv9HI03NSi/J7MmcwGOIE3TIatm
TCCDvp034+EMThEvTDODATbYyihbgihG/jjiaQwznu+A66N9lOvhKRCbiasTjTym
X06ti98dmpq9BwMd+8sRVe+U1zi9nRmGqvrcncmxUyZ1QoFdrDWFEpRog1jJvaho
8zO9NIzwsG839bqRyZIyZ0DvteaGXD7o907Nkr7aDt4jMjUmuj0ij+nrDvif9kTJ
5WOppUgN7JN4HhWNo4y5i3jei8X2TDDI9z76Juiv1DM0cbWbr2UTHSvFRysPiqGT
vCg+boC2pZd94vQKnMYbyAg+06KDneZwiNYBVQpirY3Bua7PY7TwxkBgXQfh2sNv
B2fjxmZVRMB3dWylqJmg
=wYMH
-----END PGP SIGNATURE-----

[PATCH 3/4] d3drm/tests: Split tests between different versions, initially adding frame QueryInterface tests

[Aaryaman Vasishta]

On Fri, Apr 3, 2015 at 1:45 AM, Stefan Dösinger 
wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> There are a few more issues:
>
> Am 2015-04-02 um 18:36 schrieb Aaryaman Vasishta:
> > -
> > - Copyright 2012 Andr� Hentschel
> > -
> > - Copyright 2011-2014 Henri Verbeet for CodeWeavers
>
> The encoding is still messed up.
>
> Is there any code you have taken from the other file? test_qi() is
> from dlls/ddraw/tests/ddraw*.c, so you should keep Henri's line.
> Taking along all the Copyright lines if you take something from an
> existing file is a safe choice though. Also, you should still fix your
> editor settings anyways.

I did set the editor to UTF-8 encoding, also that character does appear
properly on my vim but it's still giving this odd behaviour while copying
it over.
> You can add your own name there if you want.

I'm satisfied enough with my name being in the authors list. I don't mind
whether my name is in those files or not :).